Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2366453002: remove ETC2/EAC texture support in core WebGL 2 (Closed)

Created:
4 years, 3 months ago by Kai Ninomiya
Modified:
4 years, 2 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, blink-reviews, chromium-apps-reviews_chromium.org, haraken, piman+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove ETC2/EAC texture support in core WebGL 2 Spec change: https://github.com/KhronosGroup/WebGL/issues/2030 Test changes: https://github.com/KhronosGroup/WebGL/pull/2053 BUG=455568 BUG=655836 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/d9dc272bac64639ab80e4c782dd866b1adfd108a Cr-Commit-Position: refs/heads/master@{#425774}

Patch Set 1 : remove ETC2/EAC texture support in core WebGL 2 #

Patch Set 2 : remove ETC2/EAC texture support in core WebGL 2 #

Patch Set 3 : remove formats from build_gles2_cmd_buffer.py #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -92 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 2 3 4 1 chunk +0 lines, -20 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 3 2 chunks +0 lines, -7 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 2 2 chunks +1 line, -30 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 2 2 chunks +0 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 2 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 33 (25 generated)
Kai Ninomiya
PTAL
4 years, 2 months ago (2016-10-14 17:24:34 UTC) #9
Zhenyao Mo
On 2016/10/14 17:24:34, Kai Ninomiya wrote: > PTAL lgtm
4 years, 2 months ago (2016-10-14 17:40:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366453002/80001
4 years, 2 months ago (2016-10-14 17:40:51 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_tests_rel/builds/4486)
4 years, 2 months ago (2016-10-14 18:20:08 UTC) #17
Kai Ninomiya
On 2016/10/14 18:20:08, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 2 months ago (2016-10-14 18:32:46 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2366453002/100001
4 years, 2 months ago (2016-10-17 20:44:29 UTC) #29
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 2 months ago (2016-10-17 20:54:59 UTC) #31
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 20:57:19 UTC) #33
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d9dc272bac64639ab80e4c782dd866b1adfd108a
Cr-Commit-Position: refs/heads/master@{#425774}

Powered by Google App Engine
This is Rietveld 408576698