[Offline pages] Extracting and templatizing types for store callbacks

[Offline pages] Extracting and templatizing types for store callbacks

* Extracting ItemActionStatus, StoreState and StoreUpdateResult to
  separate header file.
* Templatizing StoreUpdateResult, providing implementation
* Updating all uses of StoreUpdateResult with OfflinePageItem type of
  the item.

BUG=645522
Committed: https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b
Cr-Commit-Position: refs/heads/master@{#420264}

[fgorski, 2016-09-21 16:28:11]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 16:28:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-09-21 16:28:49]

fgorski@chromium.org changed reviewers:
+ dimich@chromium.org, petewil@chromium.org

[fgorski, 2016-09-21 16:28:49]

Could one of you take a look, please?
Thanks.

[fgorski, 2016-09-21 16:28:50]

Could one of you take a look, please?
Thanks.

[Pete Williamson, 2016-09-21 16:56:41]

lgtm

[commit-bot: I haz the power, 2016-09-21 18:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 18:03:43]

Dry run: This issue passed the CQ dry run.

[Dmitry Titov, 2016-09-21 20:04:55]

lgtm

[fgorski, 2016-09-21 22:37:29]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 22:38:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-09-21 22:39:46]

Update:
We discussed the extra *impl.h file with Dmitry and decided to spend a few
minutes trying to remove it (and putting implementations of ctor and dtor in the
.h file), because they are not compiled until parameterized, they shouldn't be
adding to the size of binary, even when included in multiple places. Locally
things compile fine, but I need to run it on the bots anyway. If something
doesn't work, I'll revert to previously approved patch.

Thanks.
Filip

[Pete Williamson, 2016-09-21 23:13:43]

On 2016/09/21 22:39:46, fgorski wrote:
> Update:
> We discussed the extra *impl.h file with Dmitry and decided to spend a few
> minutes trying to remove it (and putting implementations of ctor and dtor in
the
> .h file), because they are not compiled until parameterized, they shouldn't be
> adding to the size of binary, even when included in multiple places. Locally
> things compile fine, but I need to run it on the bots anyway. If something
> doesn't work, I'll revert to previously approved patch.
> 
> Thanks.
> Filip

Still lgtm.

[commit-bot: I haz the power, 2016-09-22 00:07:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 00:07:58]

Dry run: This issue passed the CQ dry run.

[fgorski, 2016-09-22 05:09:41]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-09-22 05:09:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dimich@chromium.org
Link to the patchset: https://codereview.chromium.org/2353393002/#ps20001
(title: "Removing offline_store_types_impl.h")

[commit-bot: I haz the power, 2016-09-22 05:09:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 05:15:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-22 05:16:56]

Description was changed from

==========
[Offline pages] Extracting and templatizing types for store callbacks

* Extracting ItemActionStatus, StoreState and StoreUpdateResult to
  separate header file.
* Templatizing StoreUpdateResult, providing implementation
* Updating all uses of StoreUpdateResult with OfflinePageItem type of
  the item.

BUG=645522
==========

to

==========
[Offline pages] Extracting and templatizing types for store callbacks

* Extracting ItemActionStatus, StoreState and StoreUpdateResult to
  separate header file.
* Templatizing StoreUpdateResult, providing implementation
* Updating all uses of StoreUpdateResult with OfflinePageItem type of
  the item.

BUG=645522

Committed: https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b
Cr-Commit-Position: refs/heads/master@{#420264}
==========

[commit-bot: I haz the power, 2016-09-22 05:16:58]

Patchset 2 (id:??) landed as
https://crrev.com/1e681b84e34f23f18375d48afa3f249db8768e8b
Cr-Commit-Position: refs/heads/master@{#420264}