[Offline pages] Extracting and templatizing types for store callbacks

components/offline_pages/offline_page_metadata_store_sql.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_metadata_store_sql.h"
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/location.h"
@@ skipping 313 matching lines @@
   ItemActionStatus status = Insert(db, offline_page);
   runner->PostTask(FROM_HERE, base::Bind(callback, status));
 }
 
 void PostStoreUpdateResultForIds(
     scoped_refptr<base::SingleThreadTaskRunner> runner,
     StoreState store_state,
     const std::vector<int64_t>& offline_ids,
     ItemActionStatus action_status,
     const OfflinePageMetadataStore::UpdateCallback& callback) {
-  std::unique_ptr<StoreUpdateResult> result(new StoreUpdateResult(store_state));
+  std::unique_ptr<OfflinePagesUpdateResult> result(
+      new OfflinePagesUpdateResult(store_state));
   for (const auto& offline_id : offline_ids)
     result->item_statuses.push_back(std::make_pair(offline_id, action_status));
   runner->PostTask(FROM_HERE, base::Bind(callback, base::Passed(&result)));
 }
 
 void PostStoreErrorForAllPages(
     scoped_refptr<base::SingleThreadTaskRunner> runner,
     const std::vector<OfflinePageItem>& pages,
     const OfflinePageMetadataStore::UpdateCallback& callback) {
   std::vector<int64_t> offline_ids;
   for (const auto& page : pages)
     offline_ids.push_back(page.offline_id);
   PostStoreUpdateResultForIds(runner, StoreState::LOADED, offline_ids,
                               ItemActionStatus::STORE_ERROR, callback);
 }
 
 void PostStoreErrorForAllIds(
     scoped_refptr<base::SingleThreadTaskRunner> runner,
     const std::vector<int64_t>& offline_ids,
     const OfflinePageMetadataStore::UpdateCallback& callback) {
   PostStoreUpdateResultForIds(runner, StoreState::LOADED, offline_ids,
                               ItemActionStatus::STORE_ERROR, callback);
 }
 
 void UpdateOfflinePagesSync(
     sql::Connection* db,
     scoped_refptr<base::SingleThreadTaskRunner> runner,
     const std::vector<OfflinePageItem>& pages,
     const OfflinePageMetadataStore::UpdateCallback& callback) {
-  std::unique_ptr<StoreUpdateResult> result(
-      new StoreUpdateResult(StoreState::LOADED));
+  std::unique_ptr<OfflinePagesUpdateResult> result(
+      new OfflinePagesUpdateResult(StoreState::LOADED));
 
   sql::Transaction transaction(db);
   if (!transaction.Begin()) {
     PostStoreErrorForAllPages(runner, pages, callback);
     return;
   }
 
   for (const auto& page : pages) {
     if (Update(db, page)) {
       result->updated_items.push_back(page);
@@ skipping 11 matching lines @@
   }
   runner->PostTask(FROM_HERE, base::Bind(callback, base::Passed(&result)));
 }
 
 void RemoveOfflinePagesSync(
     const std::vector<int64_t>& offline_ids,
     sql::Connection* db,
     scoped_refptr<base::SingleThreadTaskRunner> runner,
     const OfflinePageMetadataStore::UpdateCallback& callback) {
   // TODO(fgorski): Perhaps add metrics here.
-  std::unique_ptr<StoreUpdateResult> result(
-      new StoreUpdateResult(StoreState::LOADED));
+  std::unique_ptr<OfflinePagesUpdateResult> result(
+      new OfflinePagesUpdateResult(StoreState::LOADED));
 
   // If you create a transaction but don't Commit() it is automatically
   // rolled back by its destructor when it falls out of scope.
   sql::Transaction transaction(db);
   if (!transaction.Begin()) {
     PostStoreErrorForAllIds(runner, offline_ids, callback);
     return;
   }
 
   for (int64_t offline_id : offline_ids) {
@@ skipping 169 matching lines @@
 bool OfflinePageMetadataStoreSQL::CheckDb(const base::Closure& callback) {
   if (!db_.get() || state_ != StoreState::LOADED) {
     base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
                                                   base::Bind(callback));
     return false;
   }
   return true;
 }
 
 }  // namespace offline_pages