Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: components/offline_pages/offline_page_metadata_store_impl_unittest.cc

Issue 2353393002: [Offline pages] Extracting and templatizing types for store callbacks (Closed)
Patch Set: Removing offline_store_types_impl.h Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/offline_page_metadata_store.h" 5 #include "components/offline_pages/offline_page_metadata_store.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
228 std::unique_ptr<OfflinePageMetadataStore> BuildStoreWithSchemaFromM53(); 228 std::unique_ptr<OfflinePageMetadataStore> BuildStoreWithSchemaFromM53();
229 std::unique_ptr<OfflinePageMetadataStore> BuildStoreWithSchemaFromM54(); 229 std::unique_ptr<OfflinePageMetadataStore> BuildStoreWithSchemaFromM54();
230 230
231 void PumpLoop(); 231 void PumpLoop();
232 232
233 void GetOfflinePagesCallback( 233 void GetOfflinePagesCallback(
234 OfflinePageMetadataStore::LoadStatus load_status, 234 OfflinePageMetadataStore::LoadStatus load_status,
235 const std::vector<OfflinePageItem>& offline_pages); 235 const std::vector<OfflinePageItem>& offline_pages);
236 void AddCallback(ItemActionStatus status); 236 void AddCallback(ItemActionStatus status);
237 void UpdateCallback(CalledCallback called_callback, 237 void UpdateCallback(CalledCallback called_callback,
238 std::unique_ptr<StoreUpdateResult> result); 238 std::unique_ptr<OfflinePagesUpdateResult> result);
239 void ResetCallback(bool status); 239 void ResetCallback(bool status);
240 240
241 void ClearResults(); 241 void ClearResults();
242 242
243 OfflinePageItem CheckThatStoreHasOneItem(); 243 OfflinePageItem CheckThatStoreHasOneItem();
244 void CheckThatOfflinePageCanBeSaved( 244 void CheckThatOfflinePageCanBeSaved(
245 std::unique_ptr<OfflinePageMetadataStore> store); 245 std::unique_ptr<OfflinePageMetadataStore> store);
246 246
247 StoreUpdateResult* last_update_result() { return last_update_result_.get(); } 247 OfflinePagesUpdateResult* last_update_result() {
248 return last_update_result_.get();
249 }
248 250
249 protected: 251 protected:
250 CalledCallback last_called_callback_; 252 CalledCallback last_called_callback_;
251 Status last_status_; 253 Status last_status_;
252 std::unique_ptr<StoreUpdateResult> last_update_result_; 254 std::unique_ptr<OfflinePagesUpdateResult> last_update_result_;
253 std::vector<OfflinePageItem> offline_pages_; 255 std::vector<OfflinePageItem> offline_pages_;
254 OfflinePageMetadataStoreFactory factory_; 256 OfflinePageMetadataStoreFactory factory_;
255 257
256 base::ScopedTempDir temp_directory_; 258 base::ScopedTempDir temp_directory_;
257 scoped_refptr<base::TestSimpleTaskRunner> task_runner_; 259 scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
258 base::ThreadTaskRunnerHandle task_runner_handle_; 260 base::ThreadTaskRunnerHandle task_runner_handle_;
259 }; 261 };
260 262
261 OfflinePageMetadataStoreTest::OfflinePageMetadataStoreTest() 263 OfflinePageMetadataStoreTest::OfflinePageMetadataStoreTest()
262 : last_called_callback_(NONE), 264 : last_called_callback_(NONE),
(...skipping 21 matching lines...) Expand all
284 void OfflinePageMetadataStoreTest::AddCallback(ItemActionStatus status) { 286 void OfflinePageMetadataStoreTest::AddCallback(ItemActionStatus status) {
285 last_called_callback_ = ADD; 287 last_called_callback_ = ADD;
286 // TODO(fgorski): Add specific add status. 288 // TODO(fgorski): Add specific add status.
287 // last_item_status_ = status; 289 // last_item_status_ = status;
288 last_status_ = 290 last_status_ =
289 status == ItemActionStatus::SUCCESS ? STATUS_TRUE : STATUS_FALSE; 291 status == ItemActionStatus::SUCCESS ? STATUS_TRUE : STATUS_FALSE;
290 } 292 }
291 293
292 void OfflinePageMetadataStoreTest::UpdateCallback( 294 void OfflinePageMetadataStoreTest::UpdateCallback(
293 CalledCallback called_callback, 295 CalledCallback called_callback,
294 std::unique_ptr<StoreUpdateResult> result) { 296 std::unique_ptr<OfflinePagesUpdateResult> result) {
295 last_called_callback_ = called_callback; 297 last_called_callback_ = called_callback;
296 last_status_ = result->updated_items.size() > 0 ? STATUS_TRUE : STATUS_FALSE; 298 last_status_ = result->updated_items.size() > 0 ? STATUS_TRUE : STATUS_FALSE;
297 last_update_result_ = std::move(result); 299 last_update_result_ = std::move(result);
298 } 300 }
299 301
300 void OfflinePageMetadataStoreTest::ResetCallback(bool status) { 302 void OfflinePageMetadataStoreTest::ResetCallback(bool status) {
301 last_called_callback_ = RESET; 303 last_called_callback_ = RESET;
302 last_status_ = status ? STATUS_TRUE : STATUS_FALSE; 304 last_status_ = status ? STATUS_TRUE : STATUS_FALSE;
303 } 305 }
304 306
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
797 base::Unretained(this))); 799 base::Unretained(this)));
798 PumpLoop(); 800 PumpLoop();
799 801
800 EXPECT_EQ(LOAD, last_called_callback_); 802 EXPECT_EQ(LOAD, last_called_callback_);
801 EXPECT_EQ(STATUS_TRUE, last_status_); 803 EXPECT_EQ(STATUS_TRUE, last_status_);
802 ASSERT_EQ(0U, offline_pages_.size()); 804 ASSERT_EQ(0U, offline_pages_.size());
803 } 805 }
804 806
805 } // namespace 807 } // namespace
806 } // namespace offline_pages 808 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/offline_page_metadata_store.cc ('k') | components/offline_pages/offline_page_metadata_store_sql.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698