Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: components/offline_pages/offline_page_test_store.cc

Issue 2353393002: [Offline pages] Extracting and templatizing types for store callbacks (Closed)
Patch Set: Removing offline_store_types_impl.h Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/offline_page_model_impl.cc ('k') | components/offline_pages/offline_page_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/offline_page_test_store.cc
diff --git a/components/offline_pages/offline_page_test_store.cc b/components/offline_pages/offline_page_test_store.cc
index e6e5637c4d0c9c06830c46e641f0f2cd4a30d98f..70b91c4e0116306876f4ef4a704cb2a076fa1d14 100644
--- a/components/offline_pages/offline_page_test_store.cc
+++ b/components/offline_pages/offline_page_test_store.cc
@@ -56,8 +56,8 @@ void OfflinePageTestStore::UpdateOfflinePages(
const UpdateCallback& callback) {
// TODO(fgorski): Cover scenario where new items are being created while they
// shouldn't.
- std::unique_ptr<StoreUpdateResult> result(
- new StoreUpdateResult(StoreState::LOADED));
+ std::unique_ptr<OfflinePagesUpdateResult> result(
+ new OfflinePagesUpdateResult(StoreState::LOADED));
if (scenario_ == TestScenario::WRITE_FAILED) {
for (const auto& page : pages) {
result->item_statuses.push_back(
@@ -81,8 +81,8 @@ void OfflinePageTestStore::UpdateOfflinePages(
void OfflinePageTestStore::RemoveOfflinePages(
const std::vector<int64_t>& offline_ids,
const UpdateCallback& callback) {
- std::unique_ptr<StoreUpdateResult> result(
- new StoreUpdateResult(StoreState::LOADED));
+ std::unique_ptr<OfflinePagesUpdateResult> result(
+ new OfflinePagesUpdateResult(StoreState::LOADED));
ASSERT_FALSE(offline_ids.empty());
if (scenario_ == TestScenario::REMOVE_FAILED) {
« no previous file with comments | « components/offline_pages/offline_page_model_impl.cc ('k') | components/offline_pages/offline_page_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698