[Offline pages] Extracting and templatizing types for store callbacks

components/offline_pages/offline_page_model_impl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_model_impl.h"
 
 #include <algorithm>
 #include <limits>
 
 #include "base/bind.h"
@@ skipping 680 matching lines @@
 
   if (paths_to_delete.empty()) {
     callback.Run(true);
     return;
   }
   archive_manager_->DeleteMultipleArchives(paths_to_delete, callback);
 }
 
 void OfflinePageModelImpl::OnExpirePageDone(
     const base::Time& expiration_time,
-    std::unique_ptr<StoreUpdateResult> result) {
+    std::unique_ptr<OfflinePagesUpdateResult> result) {
   UMA_HISTOGRAM_BOOLEAN("OfflinePages.ExpirePage.StoreUpdateResult",
                         result->updated_items.size() > 0);
   for (const auto& expired_page : result->updated_items) {
     const auto& iter = offline_pages_.find(expired_page.offline_id);
     if (iter == offline_pages_.end())
       continue;
 
     iter->second.expiration_time = expiration_time;
     ClientId client_id = iter->second.client_id;
     offline_event_logger_.RecordPageExpired(
@@ skipping 95 matching lines @@
   } else {
     PostClearStorageIfNeededTask();
   }
 
   DeletePendingArchiver(archiver);
   FOR_EACH_OBSERVER(Observer, observers_, OfflinePageModelChanged(this));
 }
 
 void OfflinePageModelImpl::OnMarkPageAccesseDone(
     const OfflinePageItem& offline_page_item,
-    std::unique_ptr<StoreUpdateResult> result) {
+    std::unique_ptr<OfflinePagesUpdateResult> result) {
   // Update the item in the cache only upon success.
   if (result->updated_items.size() > 0)
     offline_pages_[offline_page_item.offline_id] = offline_page_item;
 
   // No need to fire OfflinePageModelChanged event since updating access info
   // should not have any impact to the UI.
 }
 
 void OfflinePageModelImpl::OnEnsureArchivesDirCreatedDone(
     const base::TimeTicks& start_time) {
@@ skipping 115 matching lines @@
     return;
   }
 
   store_->RemoveOfflinePages(
       offline_ids, base::Bind(&OfflinePageModelImpl::OnRemoveOfflinePagesDone,
                               weak_ptr_factory_.GetWeakPtr(), callback));
 }
 
 void OfflinePageModelImpl::OnRemoveOfflinePagesDone(
     const DeletePageCallback& callback,
-    std::unique_ptr<StoreUpdateResult> result) {
+    std::unique_ptr<OfflinePagesUpdateResult> result) {
   ReportPageHistogramsAfterDelete(offline_pages_, result->updated_items,
                                   GetCurrentTime());
 
   // This part of the loop is explicitly broken out, as it should be gone in
   // fully asynchronous code.
   for (const auto& page : result->updated_items) {
     int64_t offline_id = page.offline_id;
     offline_event_logger_.RecordPageDeleted(std::to_string(offline_id));
     auto iter = offline_pages_.find(offline_id);
     if (iter == offline_pages_.end())
@@ skipping 180 matching lines @@
   }
 
   base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, task);
 }
 
 base::Time OfflinePageModelImpl::GetCurrentTime() const {
   return testing_clock_ ? testing_clock_->Now() : base::Time::Now();
 }
 
 }  // namespace offline_pages