Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: components/offline_pages/offline_page_model_impl.h

Issue 2353393002: [Offline pages] Extracting and templatizing types for store callbacks (Closed)
Patch Set: Removing offline_store_types_impl.h Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.h
diff --git a/components/offline_pages/offline_page_model_impl.h b/components/offline_pages/offline_page_model_impl.h
index f4f6b575e52086a7d8503ac8dd069ab7f18daf60..f66a571a6adf18db39533aded86e3cb5b63bd0d5 100644
--- a/components/offline_pages/offline_page_model_impl.h
+++ b/components/offline_pages/offline_page_model_impl.h
@@ -32,6 +32,7 @@
#include "components/offline_pages/offline_page_model_event_logger.h"
#include "components/offline_pages/offline_page_storage_manager.h"
#include "components/offline_pages/offline_page_types.h"
+#include "components/offline_pages/offline_store_types.h"
class GURL;
namespace base {
@@ -190,13 +191,14 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {
void OnDeleteArchiveFilesDone(const std::vector<int64_t>& offline_ids,
const DeletePageCallback& callback,
bool success);
- void OnRemoveOfflinePagesDone(const DeletePageCallback& callback,
- std::unique_ptr<StoreUpdateResult> result);
+ void OnRemoveOfflinePagesDone(
+ const DeletePageCallback& callback,
+ std::unique_ptr<OfflinePagesUpdateResult> result);
void InformDeletePageDone(const DeletePageCallback& callback,
DeletePageResult result);
void OnMarkPageAccesseDone(const OfflinePageItem& offline_page_item,
- std::unique_ptr<StoreUpdateResult> result);
+ std::unique_ptr<OfflinePagesUpdateResult> result);
// Callbacks for checking metadata consistency.
void CheckMetadataConsistencyForArchivePaths(
@@ -242,7 +244,7 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {
// Callback completing page expiration.
void OnExpirePageDone(const base::Time& expiration_time,
- std::unique_ptr<StoreUpdateResult> result);
+ std::unique_ptr<OfflinePagesUpdateResult> result);
// Clears expired pages if there are any.
void ClearStorageIfNeeded(
« no previous file with comments | « components/offline_pages/offline_page_metadata_store_sql.cc ('k') | components/offline_pages/offline_page_model_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698