Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2353393002: [Offline pages] Extracting and templatizing types for store callbacks (Closed)
Patch Set: Removing offline_store_types_impl.h Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.cc
diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc
index 3fab9ae3ed8e4c5bc4bdd71c3680ad71755a57e1..9b142c55a4846fa368b13fcc5c07be4f572c5407 100644
--- a/components/offline_pages/offline_page_model_impl.cc
+++ b/components/offline_pages/offline_page_model_impl.cc
@@ -698,7 +698,7 @@ void OfflinePageModelImpl::ExpirePages(
void OfflinePageModelImpl::OnExpirePageDone(
const base::Time& expiration_time,
- std::unique_ptr<StoreUpdateResult> result) {
+ std::unique_ptr<OfflinePagesUpdateResult> result) {
UMA_HISTOGRAM_BOOLEAN("OfflinePages.ExpirePage.StoreUpdateResult",
result->updated_items.size() > 0);
for (const auto& expired_page : result->updated_items) {
@@ -814,7 +814,7 @@ void OfflinePageModelImpl::OnAddOfflinePageDone(
void OfflinePageModelImpl::OnMarkPageAccesseDone(
const OfflinePageItem& offline_page_item,
- std::unique_ptr<StoreUpdateResult> result) {
+ std::unique_ptr<OfflinePagesUpdateResult> result) {
// Update the item in the cache only upon success.
if (result->updated_items.size() > 0)
offline_pages_[offline_page_item.offline_id] = offline_page_item;
@@ -950,7 +950,7 @@ void OfflinePageModelImpl::OnDeleteArchiveFilesDone(
void OfflinePageModelImpl::OnRemoveOfflinePagesDone(
const DeletePageCallback& callback,
- std::unique_ptr<StoreUpdateResult> result) {
+ std::unique_ptr<OfflinePagesUpdateResult> result) {
ReportPageHistogramsAfterDelete(offline_pages_, result->updated_items,
GetCurrentTime());
« no previous file with comments | « components/offline_pages/offline_page_model_impl.h ('k') | components/offline_pages/offline_page_test_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698