Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2351753002: Revert of Stop flattening GrCoordTransforms in parent GrFragmentProcessors. (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Stop flattening GrCoordTransforms in parent GrFragmentProcessors. (patchset #3 id:40001 of https://codereview.chromium.org/2339203002/ ) Reason for revert: Crashing blink https://codereview.chromium.org/2351743002/ Original issue's description: > Stop flattening GrCoordTransforms in parent GrFragmentProcessors. > > This changes moves to a model that iterates over GrCTs in a GrFP hierarchy when inserting transformations by GrGLSLPrimitiveProcessors. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339203002 > > Committed: https://skia.googlesource.com/skia/+/d91237ee051523f439238042674ade99207fe4a6 TBR=egdaniel@google.com,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/56b7dc476ba5e4a53ab24b5830b5ed03e404006d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -439 lines) Patch
M include/gpu/GrFragmentProcessor.h View 6 chunks +14 lines, -47 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 4 chunks +13 lines, -5 lines 0 comments Download
M src/gpu/GrFragmentProcessor.cpp View 4 chunks +9 lines, -40 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 7 chunks +24 lines, -13 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 4 chunks +42 lines, -31 lines 0 comments Download
M src/gpu/GrProgramDesc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 3 chunks +11 lines, -4 lines 0 comments Download
M src/gpu/batches/GrAnalyticRectBatch.cpp View 3 chunks +11 lines, -6 lines 0 comments Download
M src/gpu/batches/GrMSAAPathRenderer.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/batches/GrPLSPathRenderer.cpp View 7 chunks +36 lines, -17 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 9 chunks +28 lines, -12 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 3 chunks +11 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 8 chunks +25 lines, -12 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 9 chunks +10 lines, -12 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 2 chunks +8 lines, -3 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentProcessor.h View 5 chunks +4 lines, -28 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentProcessor.cpp View 4 chunks +21 lines, -31 lines 0 comments Download
M src/gpu/glsl/GrGLSLGeometryProcessor.h View 4 chunks +27 lines, -5 lines 0 comments Download
M src/gpu/glsl/GrGLSLGeometryProcessor.cpp View 1 chunk +51 lines, -62 lines 0 comments Download
M src/gpu/glsl/GrGLSLPrimitiveProcessor.h View 6 chunks +21 lines, -51 lines 0 comments Download
M src/gpu/glsl/GrGLSLPrimitiveProcessor.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramBuilder.cpp View 7 chunks +22 lines, -22 lines 0 comments Download
M src/gpu/instanced/InstanceProcessor.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M src/gpu/vk/GrVkPipelineState.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/PrimitiveProcessorTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bsalomon
Created Revert of Stop flattening GrCoordTransforms in parent GrFragmentProcessors.
4 years, 3 months ago (2016-09-19 16:26:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351753002/1
4 years, 3 months ago (2016-09-19 16:26:32 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 16:26:43 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/56b7dc476ba5e4a53ab24b5830b5ed03e404006d

Powered by Google App Engine
This is Rietveld 408576698