Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2334323005: Rename dictionary set and get methods (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename dictionary set and get methods This Cl makes the Get and Set methods consistenly use {G|S}et<Type>For. BUG=pdfium:596 Committed: https://pdfium.googlesource.com/pdfium/+/38fd84428a1ea007a043be0b7d9b289e47aa5da0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1334 lines, -1330 lines) Patch
M core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp View 6 chunks +13 lines, -13 lines 0 comments Download
M core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp View 8 chunks +13 lines, -12 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_cidfont.cpp View 7 chunks +15 lines, -15 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_font.cpp View 10 chunks +20 lines, -20 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_fontencoding.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_simplefont.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_truetypefont.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type1font.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_font/cpdf_type3font.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_colorspace.cpp View 7 chunks +13 lines, -13 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_contentmark.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_form.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_image.cpp View 10 chunks +36 lines, -36 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_meshstream.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_page.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pageobjectholder.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_shadingpattern.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_tilingpattern.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 4 chunks +14 lines, -14 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_func.cpp View 8 chunks +15 lines, -15 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 5 chunks +11 lines, -11 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 8 chunks +14 lines, -14 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cfdf_document.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp View 22 chunks +28 lines, -28 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_dictionary.cpp View 6 chunks +55 lines, -55 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 23 chunks +86 lines, -86 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp View 11 chunks +18 lines, -18 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 18 chunks +29 lines, -29 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_security_handler.cpp View 19 chunks +37 lines, -37 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_stream.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_syntax_parser.h View 1 chunk +3 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_syntax_parser.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp View 4 chunks +17 lines, -17 lines 0 comments Download
M core/fpdfapi/fpdf_parser/fpdf_parser_utility.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h View 1 chunk +33 lines, -33 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_image.cpp View 6 chunks +9 lines, -9 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 13 chunks +20 lines, -20 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 10 chunks +12 lines, -12 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_aaction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_action.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M core/fpdfdoc/cpdf_actionfields.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M core/fpdfdoc/cpdf_annot.cpp View 7 chunks +19 lines, -19 lines 0 comments Download
M core/fpdfdoc/cpdf_annotlist.cpp View 4 chunks +14 lines, -14 lines 0 comments Download
M core/fpdfdoc/cpdf_apsettings.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M core/fpdfdoc/cpdf_bookmark.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfdoc/cpdf_bookmarktree.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpdf_filespec.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M core/fpdfdoc/cpdf_filespec_unittest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpdf_formcontrol.cpp View 13 chunks +24 lines, -24 lines 0 comments Download
M core/fpdfdoc/cpdf_formfield.cpp View 17 chunks +40 lines, -40 lines 0 comments Download
M core/fpdfdoc/cpdf_formfield_unittest.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M core/fpdfdoc/cpdf_iconfit.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpdf_interform.cpp View 37 chunks +81 lines, -81 lines 0 comments Download
M core/fpdfdoc/cpdf_link.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpdf_linklist.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfdoc/cpdf_metadata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_nametree.cpp View 8 chunks +12 lines, -12 lines 0 comments Download
M core/fpdfdoc/cpdf_numbertree.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpdf_occontext.cpp View 7 chunks +22 lines, -22 lines 0 comments Download
M core/fpdfdoc/cpdf_pagelabel.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfdoc/cpdf_viewerpreferences.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M core/fpdfdoc/cpvt_fontmap.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 32 chunks +100 lines, -99 lines 0 comments Download
M core/fpdfdoc/doc_tagged.cpp View 12 chunks +31 lines, -31 lines 0 comments Download
M core/fpdfdoc/include/cpdf_action.h View 1 chunk +3 lines, -3 lines 0 comments Download
M core/fpdfdoc/include/cpdf_formcontrol.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdftext/cpdf_textpage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M core/fxge/dib/fx_dib_engine_unittest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/cba_annotiterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_baannot.cpp View 12 chunks +61 lines, -61 lines 0 comments Download
M fpdfsdk/cpdfsdk_document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/cpdfsdk_interform.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_widget.cpp View 5 chunks +18 lines, -18 lines 0 comments Download
M fpdfsdk/formfiller/cba_fontmap.cpp View 7 chunks +26 lines, -26 lines 0 comments Download
M fpdfsdk/fpdf_ext.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/fpdf_flatten.cpp View 16 chunks +44 lines, -44 lines 0 comments Download
M fpdfsdk/fpdf_transformpage.cpp View 7 chunks +14 lines, -14 lines 0 comments Download
M fpdfsdk/fpdfdoc.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/fpdfdoc_unittest.cpp View 4 chunks +40 lines, -40 lines 0 comments Download
M fpdfsdk/fpdfeditpage.cpp View 6 chunks +11 lines, -11 lines 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfppo.cpp View 10 chunks +28 lines, -27 lines 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M fpdfsdk/javascript/Document.cpp View 3 chunks +12 lines, -11 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Icon.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_ffdoc.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_fontmgr.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-09-14 21:22:17 UTC) #4
Tom Sepez
LGTM. Spot checked code.
4 years, 3 months ago (2016-09-15 17:04:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334323005/1
4 years, 3 months ago (2016-09-15 17:15:04 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-15 17:15:38 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/38fd84428a1ea007a043be0b7d9b289e47aa...

Powered by Google App Engine
This is Rietveld 408576698