Rename dictionary set and get methods

fpdfsdk/javascript/Document.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "fpdfsdk/javascript/Document.h"
 
 #include <vector>
 
@@ skipping 766 matching lines @@
     return FALSE;
   }
   if (!m_pDocument) {
     sError = JSGetStringFromID(IDS_STRING_JSBADOBJECT);
     return FALSE;
   }
   CPDF_Dictionary* pDictionary = m_pDocument->GetPDFDocument()->GetInfo();
   if (!pDictionary)
     return FALSE;
 
-  CFX_WideString cwAuthor = pDictionary->GetUnicodeTextBy("Author");
-  CFX_WideString cwTitle = pDictionary->GetUnicodeTextBy("Title");
-  CFX_WideString cwSubject = pDictionary->GetUnicodeTextBy("Subject");
-  CFX_WideString cwKeywords = pDictionary->GetUnicodeTextBy("Keywords");
-  CFX_WideString cwCreator = pDictionary->GetUnicodeTextBy("Creator");
-  CFX_WideString cwProducer = pDictionary->GetUnicodeTextBy("Producer");
-  CFX_WideString cwCreationDate = pDictionary->GetUnicodeTextBy("CreationDate");
-  CFX_WideString cwModDate = pDictionary->GetUnicodeTextBy("ModDate");
-  CFX_WideString cwTrapped = pDictionary->GetUnicodeTextBy("Trapped");
+  CFX_WideString cwAuthor = pDictionary->GetUnicodeTextFor("Author");
+  CFX_WideString cwTitle = pDictionary->GetUnicodeTextFor("Title");
+  CFX_WideString cwSubject = pDictionary->GetUnicodeTextFor("Subject");
+  CFX_WideString cwKeywords = pDictionary->GetUnicodeTextFor("Keywords");
+  CFX_WideString cwCreator = pDictionary->GetUnicodeTextFor("Creator");
+  CFX_WideString cwProducer = pDictionary->GetUnicodeTextFor("Producer");
+  CFX_WideString cwCreationDate =
+      pDictionary->GetUnicodeTextFor("CreationDate");
+  CFX_WideString cwModDate = pDictionary->GetUnicodeTextFor("ModDate");
+  CFX_WideString cwTrapped = pDictionary->GetUnicodeTextFor("Trapped");
 
   CJS_Context* pContext = (CJS_Context*)cc;
   CJS_Runtime* pRuntime = pContext->GetJSRuntime();
 
   v8::Local<v8::Object> pObj = pRuntime->NewFxDynamicObj(-1);
   pRuntime->PutObjectString(pObj, L"Author", cwAuthor);
   pRuntime->PutObjectString(pObj, L"Title", cwTitle);
   pRuntime->PutObjectString(pObj, L"Subject", cwSubject);
   pRuntime->PutObjectString(pObj, L"Keywords", cwKeywords);
   pRuntime->PutObjectString(pObj, L"Creator", cwCreator);
@@ skipping 25 matching lines @@
                                       CFX_WideString& sError) {
   if (!m_pDocument) {
     sError = JSGetStringFromID(IDS_STRING_JSBADOBJECT);
     return FALSE;
   }
   CPDF_Dictionary* pDictionary = m_pDocument->GetPDFDocument()->GetInfo();
   if (!pDictionary)
     return FALSE;
 
   if (vp.IsGetting()) {
-    vp << pDictionary->GetUnicodeTextBy(propName);
+    vp << pDictionary->GetUnicodeTextFor(propName);
   } else {
     if (!m_pDocument->GetPermissions(FPDFPERM_MODIFY)) {
       sError = JSGetStringFromID(IDS_STRING_JSNOPERMISSION);
       return FALSE;
     }
     CFX_WideString csProperty;
     vp >> csProperty;
-    pDictionary->SetAtString(propName, PDF_EncodeText(csProperty));
+    pDictionary->SetStringFor(propName, PDF_EncodeText(csProperty));
     m_pDocument->SetChangeMark();
   }
   return TRUE;
 }
 
 FX_BOOL Document::creationDate(IJS_Context* cc,
                                CJS_PropValue& vp,
                                CFX_WideString& sError) {
   return getPropertyInternal(cc, vp, "CreationDate", sError);
 }
@@ skipping 859 matching lines @@
     }
   }
 
   for (const auto& pData : DelayDataForFieldAndControlIndex)
     Field::DoDelay(m_pDocument.Get(), pData.get());
 }
 
 CJS_Document* Document::GetCJSDoc() const {
   return static_cast<CJS_Document*>(m_pJSObject);
 }