Rename dictionary set and get methods

xfa/fxfa/fm2js/xfa_fm2jscontext.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/fm2js/xfa_fm2jscontext.h"
 
 #include <time.h>
 
@@ skipping 5554 matching lines @@
   }
 
   XFA_RESOLVENODE_RS resoveNodeRS;
   int32_t iRet = 0;
   CFX_ByteString bsAccessorName = args.GetUTF8String(1);
   if (argAccessor->IsObject() ||
       (argAccessor->IsNull() && bsAccessorName.IsEmpty())) {
     iRet = ResolveObjects(pThis, argAccessor.get(), szSomExp.AsStringC(),
                           resoveNodeRS, TRUE, szName.IsEmpty());
   } else if (!argAccessor->IsObject() && !bsAccessorName.IsEmpty() &&
-             GetObjectByName(pThis, argAccessor.get(),
-                             bsAccessorName.AsStringC())) {
+             GetObjectForName(pThis, argAccessor.get(),
+                              bsAccessorName.AsStringC())) {
     iRet = ResolveObjects(pThis, argAccessor.get(), szSomExp.AsStringC(),
                           resoveNodeRS, TRUE, szName.IsEmpty());
   }
   if (iRet < 1) {
     CFX_WideString wsPropertyName =
         CFX_WideString::FromUTF8(szName.AsStringC());
     CFX_WideString wsSomExpression =
         CFX_WideString::FromUTF8(szSomExp.AsStringC());
     pContext->ThrowException(XFA_IDS_ACCESS_PROPERTY_IN_NOT_OBJECT,
                              wsPropertyName.c_str(), wsSomExpression.c_str());
@@ skipping 116 matching lines @@
   }
 
   XFA_RESOLVENODE_RS resoveNodeRS;
   int32_t iRet = 0;
   CFX_ByteString bsAccessorName = args.GetUTF8String(1);
   if (argAccessor->IsObject() ||
       (argAccessor->IsNull() && bsAccessorName.IsEmpty())) {
     iRet = ResolveObjects(pThis, argAccessor.get(), szSomExp.AsStringC(),
                           resoveNodeRS, FALSE);
   } else if (!argAccessor->IsObject() && !bsAccessorName.IsEmpty() &&
-             GetObjectByName(pThis, argAccessor.get(),
-                             bsAccessorName.AsStringC())) {
+             GetObjectForName(pThis, argAccessor.get(),
+                              bsAccessorName.AsStringC())) {
     iRet = ResolveObjects(pThis, argAccessor.get(), szSomExp.AsStringC(),
                           resoveNodeRS, FALSE);
   }
   if (iRet < 1) {
     CFX_WideString wsPropertyName =
         CFX_WideString::FromUTF8(szName.AsStringC());
     CFX_WideString wsSomExpression =
         CFX_WideString::FromUTF8(szSomExp.AsStringC());
     pContext->ThrowException(XFA_IDS_ACCESS_PROPERTY_IN_NOT_OBJECT,
                              wsPropertyName.c_str(), wsSomExpression.c_str());
@@ skipping 471 matching lines @@
     szSomExp += "]";
   } else {
     szSomExp = (iIndexValue < 0) ? (szName + "[") : (szName + "[-");
     iIndexValue = (iIndexValue < 0) ? (0 - iIndexValue) : iIndexValue;
     szSomExp += CFX_ByteString::FormatInteger(iIndexValue);
     szSomExp += "]";
   }
 }
 
 // static
-FX_BOOL CXFA_FM2JSContext::GetObjectByName(
+FX_BOOL CXFA_FM2JSContext::GetObjectForName(
     CFXJSE_Value* pThis,
     CFXJSE_Value* accessorValue,
     const CFX_ByteStringC& szAccessorName) {
   CXFA_Document* pDoc = ToJSContext(pThis, nullptr)->GetDocument();
   if (!pDoc)
     return FALSE;
 
   CXFA_ScriptContext* pScriptContext = pDoc->GetScriptContext();
   XFA_RESOLVENODE_RS resoveNodeRS;
   uint32_t dwFlags = XFA_RESOLVENODE_Children | XFA_RESOLVENODE_Properties |
@@ skipping 301 matching lines @@
   CFX_WideString wsFormat;
   pAppProvider->LoadString(iStringID, wsFormat);
   CFX_WideString wsMessage;
   va_list arg_ptr;
   va_start(arg_ptr, iStringID);
   wsMessage.FormatV(wsFormat.c_str(), arg_ptr);
   va_end(arg_ptr);
   FXJSE_ThrowMessage(
       FX_UTF8Encode(wsMessage.c_str(), wsMessage.GetLength()).AsStringC());
 }