Rename dictionary set and get methods

core/fpdfdoc/cpdf_occontext.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfdoc/include/cpdf_occontext.h"
 
 #include "core/fpdfapi/fpdf_page/include/cpdf_pageobject.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h"
 
 namespace {
 
 int32_t FindGroup(const CPDF_Array* pArray, const CPDF_Dictionary* pGroupDict) {
   if (!pArray || !pGroupDict)
     return -1;
 
   for (size_t i = 0; i < pArray->GetCount(); i++) {
     if (pArray->GetDictAt(i) == pGroupDict)
       return i;
   }
   return -1;
 }
 
 bool HasIntent(const CPDF_Dictionary* pDict,
                const CFX_ByteStringC& csElement,
                const CFX_ByteStringC& csDef) {
-  CPDF_Object* pIntent = pDict->GetDirectObjectBy("Intent");
+  CPDF_Object* pIntent = pDict->GetDirectObjectFor("Intent");
   if (!pIntent)
     return csElement == csDef;
 
   CFX_ByteString bsIntent;
   if (CPDF_Array* pArray = pIntent->AsArray()) {
     for (size_t i = 0; i < pArray->GetCount(); i++) {
       bsIntent = pArray->GetStringAt(i);
       if (bsIntent == "All" || bsIntent == csElement)
         return true;
     }
     return false;
   }
   bsIntent = pIntent->GetString();
   return bsIntent == "All" || bsIntent == csElement;
 }
 
 CPDF_Dictionary* GetConfig(CPDF_Document* pDoc,
                            const CPDF_Dictionary* pOCGDict) {
   ASSERT(pOCGDict);
-  CPDF_Dictionary* pOCProperties = pDoc->GetRoot()->GetDictBy("OCProperties");
+  CPDF_Dictionary* pOCProperties = pDoc->GetRoot()->GetDictFor("OCProperties");
   if (!pOCProperties)
     return nullptr;
 
-  CPDF_Array* pOCGs = pOCProperties->GetArrayBy("OCGs");
+  CPDF_Array* pOCGs = pOCProperties->GetArrayFor("OCGs");
   if (!pOCGs)
     return nullptr;
 
   if (FindGroup(pOCGs, pOCGDict) < 0)
     return nullptr;
 
-  CPDF_Dictionary* pConfig = pOCProperties->GetDictBy("D");
-  CPDF_Array* pConfigs = pOCProperties->GetArrayBy("Configs");
+  CPDF_Dictionary* pConfig = pOCProperties->GetDictFor("D");
+  CPDF_Array* pConfigs = pOCProperties->GetArrayFor("Configs");
   if (!pConfigs)
     return pConfig;
 
   for (size_t i = 0; i < pConfigs->GetCount(); i++) {
     CPDF_Dictionary* pFind = pConfigs->GetDictAt(i);
     if (pFind && HasIntent(pFind, "View", "View"))
       return pFind;
   }
   return pConfig;
 }
@@ skipping 26 matching lines @@
 
 CPDF_OCContext::~CPDF_OCContext() {}
 
 bool CPDF_OCContext::LoadOCGStateFromConfig(
     const CFX_ByteString& csConfig,
     const CPDF_Dictionary* pOCGDict) const {
   CPDF_Dictionary* pConfig = GetConfig(m_pDocument, pOCGDict);
   if (!pConfig)
     return true;
 
-  bool bState = pConfig->GetStringBy("BaseState", "ON") != "OFF";
-  CPDF_Array* pArray = pConfig->GetArrayBy("ON");
+  bool bState = pConfig->GetStringFor("BaseState", "ON") != "OFF";
+  CPDF_Array* pArray = pConfig->GetArrayFor("ON");
   if (pArray) {
     if (FindGroup(pArray, pOCGDict) >= 0)
       bState = true;
   }
-  pArray = pConfig->GetArrayBy("OFF");
+  pArray = pConfig->GetArrayFor("OFF");
   if (pArray) {
     if (FindGroup(pArray, pOCGDict) >= 0)
       bState = false;
   }
-  pArray = pConfig->GetArrayBy("AS");
+  pArray = pConfig->GetArrayFor("AS");
   if (!pArray)
     return bState;
 
   CFX_ByteString csFind = csConfig + "State";
   for (size_t i = 0; i < pArray->GetCount(); i++) {
     CPDF_Dictionary* pUsage = pArray->GetDictAt(i);
     if (!pUsage)
       continue;
 
-    if (pUsage->GetStringBy("Event", "View") != csConfig)
+    if (pUsage->GetStringFor("Event", "View") != csConfig)
       continue;
 
-    CPDF_Array* pOCGs = pUsage->GetArrayBy("OCGs");
+    CPDF_Array* pOCGs = pUsage->GetArrayFor("OCGs");
     if (!pOCGs)
       continue;
 
     if (FindGroup(pOCGs, pOCGDict) < 0)
       continue;
 
-    CPDF_Dictionary* pState = pUsage->GetDictBy(csConfig);
+    CPDF_Dictionary* pState = pUsage->GetDictFor(csConfig);
     if (!pState)
       continue;
 
-    bState = pState->GetStringBy(csFind) != "OFF";
+    bState = pState->GetStringFor(csFind) != "OFF";
   }
   return bState;
 }
 
 bool CPDF_OCContext::LoadOCGState(const CPDF_Dictionary* pOCGDict) const {
   if (!HasIntent(pOCGDict, "View", "View"))
     return true;
 
   CFX_ByteString csState = GetUsageTypeString(m_eUsageType);
-  CPDF_Dictionary* pUsage = pOCGDict->GetDictBy("Usage");
+  CPDF_Dictionary* pUsage = pOCGDict->GetDictFor("Usage");
   if (pUsage) {
-    CPDF_Dictionary* pState = pUsage->GetDictBy(csState);
+    CPDF_Dictionary* pState = pUsage->GetDictFor(csState);
     if (pState) {
       CFX_ByteString csFind = csState + "State";
       if (pState->KeyExist(csFind))
-        return pState->GetStringBy(csFind) != "OFF";
+        return pState->GetStringFor(csFind) != "OFF";
     }
     if (csState != "View") {
-      pState = pUsage->GetDictBy("View");
+      pState = pUsage->GetDictFor("View");
       if (pState && pState->KeyExist("ViewState"))
-        return pState->GetStringBy("ViewState") != "OFF";
+        return pState->GetStringFor("ViewState") != "OFF";
     }
   }
   return LoadOCGStateFromConfig(csState, pOCGDict);
 }
 
 bool CPDF_OCContext::GetOCGVisible(const CPDF_Dictionary* pOCGDict) {
   if (!pOCGDict)
     return false;
 
   const auto it = m_OCGStates.find(pOCGDict);
@@ skipping 55 matching lines @@
         bValue = bValue || bItem;
       } else {
         bValue = bValue && bItem;
       }
     }
   }
   return bValue;
 }
 
 bool CPDF_OCContext::LoadOCMDState(const CPDF_Dictionary* pOCMDDict) {
-  CPDF_Array* pVE = pOCMDDict->GetArrayBy("VE");
+  CPDF_Array* pVE = pOCMDDict->GetArrayFor("VE");
   if (pVE)
     return GetOCGVE(pVE, 0);
 
-  CFX_ByteString csP = pOCMDDict->GetStringBy("P", "AnyOn");
-  CPDF_Object* pOCGObj = pOCMDDict->GetDirectObjectBy("OCGs");
+  CFX_ByteString csP = pOCMDDict->GetStringFor("P", "AnyOn");
+  CPDF_Object* pOCGObj = pOCMDDict->GetDirectObjectFor("OCGs");
   if (!pOCGObj)
     return true;
 
   if (const CPDF_Dictionary* pDict = pOCGObj->AsDictionary())
     return GetOCGVisible(pDict);
 
   CPDF_Array* pArray = pOCGObj->AsArray();
   if (!pArray)
     return true;
 
   bool bState = (csP == "AllOn" || csP == "AllOff");
   for (size_t i = 0; i < pArray->GetCount(); i++) {
     bool bItem = true;
     CPDF_Dictionary* pItemDict = pArray->GetDictAt(i);
     if (pItemDict)
       bItem = GetOCGVisible(pItemDict);
 
     if ((csP == "AnyOn" && bItem) || (csP == "AnyOff" && !bItem))
       return true;
     if ((csP == "AllOn" && !bItem) || (csP == "AllOff" && bItem))
       return false;
   }
   return bState;
 }
 
 bool CPDF_OCContext::CheckOCGVisible(const CPDF_Dictionary* pOCGDict) {
   if (!pOCGDict)
     return true;
 
-  CFX_ByteString csType = pOCGDict->GetStringBy("Type", "OCG");
+  CFX_ByteString csType = pOCGDict->GetStringFor("Type", "OCG");
   if (csType == "OCG")
     return GetOCGVisible(pOCGDict);
   return LoadOCMDState(pOCGDict);
 }