Rename dictionary set and get methods

core/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_parser/include/fpdf_parser_decode.h"
 
 #include <limits.h>
 #include <utility>
@@ skipping 221 matching lines @@
     int width,
     int height,
     const CPDF_Dictionary* pParams) {
   int K = 0;
   FX_BOOL EndOfLine = FALSE;
   FX_BOOL ByteAlign = FALSE;
   FX_BOOL BlackIs1 = FALSE;
   int Columns = 1728;
   int Rows = 0;
   if (pParams) {
-    K = pParams->GetIntegerBy("K");
-    EndOfLine = pParams->GetIntegerBy("EndOfLine");
-    ByteAlign = pParams->GetIntegerBy("EncodedByteAlign");
-    BlackIs1 = pParams->GetIntegerBy("BlackIs1");
-    Columns = pParams->GetIntegerBy("Columns", 1728);
-    Rows = pParams->GetIntegerBy("Rows");
+    K = pParams->GetIntegerFor("K");
+    EndOfLine = pParams->GetIntegerFor("EndOfLine");
+    ByteAlign = pParams->GetIntegerFor("EncodedByteAlign");
+    BlackIs1 = pParams->GetIntegerFor("BlackIs1");
+    Columns = pParams->GetIntegerFor("Columns", 1728);
+    Rows = pParams->GetIntegerFor("Rows");
     if (Rows > USHRT_MAX) {
       Rows = 0;
     }
     if (Columns <= 0 || Rows < 0 || Columns > USHRT_MAX || Rows > USHRT_MAX) {
       return nullptr;
     }
   }
   return CPDF_ModuleMgr::Get()->GetFaxModule()->CreateDecoder(
       src_buf, src_size, width, height, K, EndOfLine, ByteAlign, BlackIs1,
       Columns, Rows);
@@ skipping 25 matching lines @@
     const uint8_t* src_buf,
     uint32_t src_size,
     int width,
     int height,
     int nComps,
     int bpc,
     const CPDF_Dictionary* pParams) {
   int predictor = 0;
   int Colors = 0, BitsPerComponent = 0, Columns = 0;
   if (pParams) {
-    predictor = pParams->GetIntegerBy("Predictor");
-    Colors = pParams->GetIntegerBy("Colors", 1);
-    BitsPerComponent = pParams->GetIntegerBy("BitsPerComponent", 8);
-    Columns = pParams->GetIntegerBy("Columns", 1);
+    predictor = pParams->GetIntegerFor("Predictor");
+    Colors = pParams->GetIntegerFor("Colors", 1);
+    BitsPerComponent = pParams->GetIntegerFor("BitsPerComponent", 8);
+    Columns = pParams->GetIntegerFor("Columns", 1);
     if (!CheckFlateDecodeParams(Colors, BitsPerComponent, Columns)) {
       return nullptr;
     }
   }
   return CPDF_ModuleMgr::Get()->GetFlateModule()->CreateDecoder(
       src_buf, src_size, width, height, nComps, bpc, predictor, Colors,
       BitsPerComponent, Columns);
 }
 
 uint32_t FPDFAPI_FlateOrLZWDecode(FX_BOOL bLZW,
                                   const uint8_t* src_buf,
                                   uint32_t src_size,
                                   CPDF_Dictionary* pParams,
                                   uint32_t estimated_size,
                                   uint8_t*& dest_buf,
                                   uint32_t& dest_size) {
   int predictor = 0;
   FX_BOOL bEarlyChange = TRUE;
   int Colors = 0, BitsPerComponent = 0, Columns = 0;
   if (pParams) {
-    predictor = pParams->GetIntegerBy("Predictor");
-    bEarlyChange = pParams->GetIntegerBy("EarlyChange", 1);
-    Colors = pParams->GetIntegerBy("Colors", 1);
-    BitsPerComponent = pParams->GetIntegerBy("BitsPerComponent", 8);
-    Columns = pParams->GetIntegerBy("Columns", 1);
+    predictor = pParams->GetIntegerFor("Predictor");
+    bEarlyChange = pParams->GetIntegerFor("EarlyChange", 1);
+    Colors = pParams->GetIntegerFor("Colors", 1);
+    BitsPerComponent = pParams->GetIntegerFor("BitsPerComponent", 8);
+    Columns = pParams->GetIntegerFor("Columns", 1);
     if (!CheckFlateDecodeParams(Colors, BitsPerComponent, Columns)) {
       return (uint32_t)-1;
     }
   }
   return CPDF_ModuleMgr::Get()->GetFlateModule()->FlateOrLZWDecode(
       bLZW, src_buf, src_size, bEarlyChange, predictor, Colors,
       BitsPerComponent, Columns, estimated_size, dest_buf, dest_size);
 }
 
 FX_BOOL PDF_DataDecode(const uint8_t* src_buf,
                        uint32_t src_size,
                        const CPDF_Dictionary* pDict,
                        uint8_t*& dest_buf,
                        uint32_t& dest_size,
                        CFX_ByteString& ImageEncoding,
                        CPDF_Dictionary*& pImageParms,
                        uint32_t last_estimated_size,
                        FX_BOOL bImageAcc) {
-  CPDF_Object* pDecoder = pDict ? pDict->GetDirectObjectBy("Filter") : nullptr;
+  CPDF_Object* pDecoder = pDict ? pDict->GetDirectObjectFor("Filter") : nullptr;
   if (!pDecoder || (!pDecoder->IsArray() && !pDecoder->IsName()))
     return FALSE;
 
   CPDF_Object* pParams =
-      pDict ? pDict->GetDirectObjectBy("DecodeParms") : nullptr;
+      pDict ? pDict->GetDirectObjectFor("DecodeParms") : nullptr;
 
   std::vector<std::pair<CFX_ByteString, CPDF_Object*>> DecoderArray;
   if (CPDF_Array* pDecoders = pDecoder->AsArray()) {
     CPDF_Array* pParamsArray = ToArray(pParams);
     for (size_t i = 0; i < pDecoders->GetCount(); i++) {
       DecoderArray.push_back(
           {pDecoders->GetStringAt(i),
            pParamsArray ? pParamsArray->GetDictAt(i) : nullptr});
     }
   } else {
@@ skipping 216 matching lines @@
                      uint32_t src_size,
                      uint8_t*& dest_buf,
                      uint32_t& dest_size) {
   CCodec_ModuleMgr* pEncoders = CPDF_ModuleMgr::Get()->GetCodecModule();
   if (pEncoders) {
     return pEncoders->GetFlateModule()->FlateOrLZWDecode(
         FALSE, src_buf, src_size, FALSE, 0, 0, 0, 0, 0, dest_buf, dest_size);
   }
   return 0;
 }