Rename dictionary set and get methods

xfa/fxfa/app/xfa_fontmgr.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/include/xfa_fontmgr.h"
 
 #include <algorithm>
 #include <utility>
@@ skipping 1820 matching lines @@
 CFGAS_GEFont* CXFA_PDFFontMgr::FindFont(CFX_ByteString strPsName,
                                         FX_BOOL bBold,
                                         FX_BOOL bItalic,
                                         CPDF_Font** pDstPDFFont,
                                         FX_BOOL bStrictMatch) {
   CPDF_Document* pDoc = m_pDoc->GetPDFDoc();
   if (!pDoc) {
     return nullptr;
   }
   CPDF_Dictionary* pFontSetDict =
-      pDoc->GetRoot()->GetDictBy("AcroForm")->GetDictBy("DR");
+      pDoc->GetRoot()->GetDictFor("AcroForm")->GetDictFor("DR");
   if (!pFontSetDict) {
     return nullptr;
   }
-  pFontSetDict = pFontSetDict->GetDictBy("Font");
+  pFontSetDict = pFontSetDict->GetDictFor("Font");
   if (!pFontSetDict) {
     return nullptr;
   }
   strPsName.Remove(' ');
   IFGAS_FontMgr* pFDEFontMgr = m_pDoc->GetApp()->GetFDEFontMgr();
   for (const auto& it : *pFontSetDict) {
     const CFX_ByteString& key = it.first;
     CPDF_Object* pObj = it.second;
     if (!PsNameMatchDRFontName(strPsName.AsStringC(), bBold, bItalic, key,
                                bStrictMatch)) {
       continue;
     }
     CPDF_Dictionary* pFontDict = ToDictionary(pObj->GetDirect());
-    if (!pFontDict || pFontDict->GetStringBy("Type") != "Font") {
+    if (!pFontDict || pFontDict->GetStringFor("Type") != "Font") {
       return nullptr;
     }
     CPDF_Font* pPDFFont = pDoc->LoadFont(pFontDict);
     if (!pPDFFont) {
       return nullptr;
     }
     if (!pPDFFont->IsEmbedded()) {
       *pDstPDFFont = pPDFFont;
       return nullptr;
     }
@@ skipping 183 matching lines @@
     m_PDFFontMgrMap[hDoc].reset(new CXFA_PDFFontMgr(hDoc));
 }
 
 void CXFA_FontMgr::ReleaseDocFonts(CXFA_FFDoc* hDoc) {
   m_PDFFontMgrMap.erase(hDoc);
 }
 
 void CXFA_FontMgr::SetDefFontMgr(std::unique_ptr<CXFA_DefFontMgr> pFontMgr) {
   m_pDefFontMgr = std::move(pFontMgr);
 }