Rename dictionary set and get methods

fpdfsdk/fpdf_flatten.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "public/fpdf_flatten.h"
 
 #include <algorithm>
 
@@ skipping 37 matching lines @@
                      CPDF_RectArray* pRectArray) {
   std::unique_ptr<CPDF_Page> pPDFPage(new CPDF_Page(pDoc, pDict, false));
   pPDFPage->ParseContent();
 
   for (const auto& pPageObject : *pPDFPage->GetPageObjectList()) {
     CFX_FloatRect rc;
     rc.left = pPageObject->m_Left;
     rc.right = pPageObject->m_Right;
     rc.bottom = pPageObject->m_Bottom;
     rc.top = pPageObject->m_Top;
-    if (IsValiableRect(rc, pDict->GetRectBy("MediaBox")))
+    if (IsValiableRect(rc, pDict->GetRectFor("MediaBox")))
       pRectArray->Add(rc);
   }
 }
 
 void ParserStream(CPDF_Dictionary* pPageDic,
                   CPDF_Dictionary* pStream,
                   CPDF_RectArray* pRectArray,
                   CPDF_ObjectArray* pObjectArray) {
   if (!pStream)
     return;
   CFX_FloatRect rect;
   if (pStream->KeyExist("Rect"))
-    rect = pStream->GetRectBy("Rect");
+    rect = pStream->GetRectFor("Rect");
   else if (pStream->KeyExist("BBox"))
-    rect = pStream->GetRectBy("BBox");
+    rect = pStream->GetRectFor("BBox");
 
-  if (IsValiableRect(rect, pPageDic->GetRectBy("MediaBox")))
+  if (IsValiableRect(rect, pPageDic->GetRectFor("MediaBox")))
     pRectArray->Add(rect);
 
   pObjectArray->Add(pStream);
 }
 
 int ParserAnnots(CPDF_Document* pSourceDoc,
                  CPDF_Dictionary* pPageDic,
                  CPDF_RectArray* pRectArray,
                  CPDF_ObjectArray* pObjectArray,
                  int nUsage) {
   if (!pSourceDoc || !pPageDic)
     return FLATTEN_FAIL;
 
   GetContentsRect(pSourceDoc, pPageDic, pRectArray);
-  CPDF_Array* pAnnots = pPageDic->GetArrayBy("Annots");
+  CPDF_Array* pAnnots = pPageDic->GetArrayFor("Annots");
   if (!pAnnots)
     return FLATTEN_NOTHINGTODO;
 
   uint32_t dwSize = pAnnots->GetCount();
   for (int i = 0; i < (int)dwSize; i++) {
     CPDF_Dictionary* pAnnotDic = ToDictionary(pAnnots->GetDirectObjectAt(i));
     if (!pAnnotDic)
       continue;
 
-    CFX_ByteString sSubtype = pAnnotDic->GetStringBy("Subtype");
+    CFX_ByteString sSubtype = pAnnotDic->GetStringFor("Subtype");
     if (sSubtype == "Popup")
       continue;
 
-    int nAnnotFlag = pAnnotDic->GetIntegerBy("F");
+    int nAnnotFlag = pAnnotDic->GetIntegerFor("F");
     if (nAnnotFlag & ANNOTFLAG_HIDDEN)
       continue;
 
     if (nUsage == FLAT_NORMALDISPLAY) {
       if (nAnnotFlag & ANNOTFLAG_INVISIBLE)
         continue;
 
       ParserStream(pPageDic, pAnnotDic, pRectArray, pObjectArray);
     } else {
       if (nAnnotFlag & ANNOTFLAG_PRINT)
@@ skipping 63 matching lines @@
   rcRet.top = GetMinMaxValue(*pRectArray, MAX, TOP);
   rcRet.right = GetMinMaxValue(*pRectArray, MAX, RIGHT);
   rcRet.bottom = GetMinMaxValue(*pRectArray, MIN, BOTTOM);
 
   return rcRet;
 }
 
 void SetPageContents(CFX_ByteString key,
                      CPDF_Dictionary* pPage,
                      CPDF_Document* pDocument) {
-  CPDF_Object* pContentsObj = pPage->GetStreamBy("Contents");
+  CPDF_Object* pContentsObj = pPage->GetStreamFor("Contents");
   if (!pContentsObj) {
-    pContentsObj = pPage->GetArrayBy("Contents");
+    pContentsObj = pPage->GetArrayFor("Contents");
   }
 
   if (!pContentsObj) {
     // Create a new contents dictionary
     if (!key.IsEmpty()) {
       CPDF_Stream* pNewContents =
           new CPDF_Stream(nullptr, 0, new CPDF_Dictionary);
-      pPage->SetAtReference("Contents", pDocument,
-                            pDocument->AddIndirectObject(pNewContents));
+      pPage->SetReferenceFor("Contents", pDocument,
+                             pDocument->AddIndirectObject(pNewContents));
 
       CFX_ByteString sStream;
       sStream.Format("q 1 0 0 1 0 0 cm /%s Do Q", key.c_str());
       pNewContents->SetData(sStream.raw_str(), sStream.GetLength(), FALSE,
                             FALSE);
     }
     return;
   }
 
   CPDF_Array* pContentsArray = nullptr;
@@ skipping 19 matching lines @@
       break;
     }
     default:
       break;
   }
 
   if (!pContentsArray)
     return;
 
   uint32_t dwObjNum = pDocument->AddIndirectObject(pContentsArray);
-  pPage->SetAtReference("Contents", pDocument, dwObjNum);
+  pPage->SetReferenceFor("Contents", pDocument, dwObjNum);
 
   if (!key.IsEmpty()) {
     CPDF_Stream* pNewContents =
         new CPDF_Stream(nullptr, 0, new CPDF_Dictionary);
     dwObjNum = pDocument->AddIndirectObject(pNewContents);
     pContentsArray->AddReference(pDocument, dwObjNum);
 
     CFX_ByteString sStream;
     sStream.Format("q 1 0 0 1 0 0 cm /%s Do Q", key.c_str());
     pNewContents->SetData(sStream.raw_str(), sStream.GetLength(), FALSE, FALSE);
@@ skipping 73 matching lines @@
   CPDF_ObjectArray ObjectArray;
   CPDF_RectArray RectArray;
 
   int iRet = FLATTEN_FAIL;
   iRet = ParserAnnots(pDocument, pPageDict, &RectArray, &ObjectArray, nFlag);
   if (iRet == FLATTEN_NOTHINGTODO || iRet == FLATTEN_FAIL)
     return iRet;
 
   CFX_FloatRect rcOriginalCB;
   CFX_FloatRect rcMerger = CalculateRect(&RectArray);
-  CFX_FloatRect rcOriginalMB = pPageDict->GetRectBy("MediaBox");
+  CFX_FloatRect rcOriginalMB = pPageDict->GetRectFor("MediaBox");
 
   if (pPageDict->KeyExist("CropBox"))
-    rcOriginalMB = pPageDict->GetRectBy("CropBox");
+    rcOriginalMB = pPageDict->GetRectFor("CropBox");
 
   if (rcOriginalMB.IsEmpty()) {
     rcOriginalMB = CFX_FloatRect(0.0f, 0.0f, 612.0f, 792.0f);
   }
 
   rcMerger.left =
       rcMerger.left < rcOriginalMB.left ? rcOriginalMB.left : rcMerger.left;
   rcMerger.right =
       rcMerger.right > rcOriginalMB.right ? rcOriginalMB.right : rcMerger.right;
   rcMerger.top =
       rcMerger.top > rcOriginalMB.top ? rcOriginalMB.top : rcMerger.top;
   rcMerger.bottom = rcMerger.bottom < rcOriginalMB.bottom ? rcOriginalMB.bottom
                                                           : rcMerger.bottom;
 
   if (pPageDict->KeyExist("ArtBox"))
-    rcOriginalCB = pPageDict->GetRectBy("ArtBox");
+    rcOriginalCB = pPageDict->GetRectFor("ArtBox");
   else
     rcOriginalCB = rcOriginalMB;
 
   if (!rcOriginalMB.IsEmpty()) {
     CPDF_Array* pMediaBox = new CPDF_Array();
     pMediaBox->Add(new CPDF_Number(rcOriginalMB.left));
     pMediaBox->Add(new CPDF_Number(rcOriginalMB.bottom));
     pMediaBox->Add(new CPDF_Number(rcOriginalMB.right));
     pMediaBox->Add(new CPDF_Number(rcOriginalMB.top));
-    pPageDict->SetAt("MediaBox", pMediaBox);
+    pPageDict->SetFor("MediaBox", pMediaBox);
   }
 
   if (!rcOriginalCB.IsEmpty()) {
     CPDF_Array* pCropBox = new CPDF_Array();
     pCropBox->Add(new CPDF_Number(rcOriginalCB.left));
     pCropBox->Add(new CPDF_Number(rcOriginalCB.bottom));
     pCropBox->Add(new CPDF_Number(rcOriginalCB.right));
     pCropBox->Add(new CPDF_Number(rcOriginalCB.top));
-    pPageDict->SetAt("ArtBox", pCropBox);
+    pPageDict->SetFor("ArtBox", pCropBox);
   }
 
-  CPDF_Dictionary* pRes = pPageDict->GetDictBy("Resources");
+  CPDF_Dictionary* pRes = pPageDict->GetDictFor("Resources");
   if (!pRes) {
     pRes = new CPDF_Dictionary;
-    pPageDict->SetAt("Resources", pRes);
+    pPageDict->SetFor("Resources", pRes);
   }
 
   CPDF_Stream* pNewXObject = new CPDF_Stream(nullptr, 0, new CPDF_Dictionary);
   uint32_t dwObjNum = pDocument->AddIndirectObject(pNewXObject);
-  CPDF_Dictionary* pPageXObject = pRes->GetDictBy("XObject");
+  CPDF_Dictionary* pPageXObject = pRes->GetDictFor("XObject");
   if (!pPageXObject) {
     pPageXObject = new CPDF_Dictionary;
-    pRes->SetAt("XObject", pPageXObject);
+    pRes->SetFor("XObject", pPageXObject);
   }
 
   CFX_ByteString key = "";
   int nStreams = ObjectArray.GetSize();
 
   if (nStreams > 0) {
     for (int iKey = 0; /*iKey < 100*/; iKey++) {
       char sExtend[5] = {};
       FXSYS_itoa(iKey, sExtend, 10);
       key = CFX_ByteString("FFT") + CFX_ByteString(sExtend);
       if (!pPageXObject->KeyExist(key))
         break;
     }
   }
 
   SetPageContents(key, pPageDict, pDocument);
 
   CPDF_Dictionary* pNewXORes = nullptr;
 
   if (!key.IsEmpty()) {
-    pPageXObject->SetAtReference(key, pDocument, dwObjNum);
+    pPageXObject->SetReferenceFor(key, pDocument, dwObjNum);
     CPDF_Dictionary* pNewOXbjectDic = pNewXObject->GetDict();
     pNewXORes = new CPDF_Dictionary;
-    pNewOXbjectDic->SetAt("Resources", pNewXORes);
-    pNewOXbjectDic->SetAtName("Type", "XObject");
-    pNewOXbjectDic->SetAtName("Subtype", "Form");
-    pNewOXbjectDic->SetAtInteger("FormType", 1);
-    pNewOXbjectDic->SetAtName("Name", "FRM");
-    CFX_FloatRect rcBBox = pPageDict->GetRectBy("ArtBox");
-    pNewOXbjectDic->SetAtRect("BBox", rcBBox);
+    pNewOXbjectDic->SetFor("Resources", pNewXORes);
+    pNewOXbjectDic->SetNameFor("Type", "XObject");
+    pNewOXbjectDic->SetNameFor("Subtype", "Form");
+    pNewOXbjectDic->SetIntegerFor("FormType", 1);
+    pNewOXbjectDic->SetNameFor("Name", "FRM");
+    CFX_FloatRect rcBBox = pPageDict->GetRectFor("ArtBox");
+    pNewOXbjectDic->SetRectFor("BBox", rcBBox);
   }
 
   for (int i = 0; i < nStreams; i++) {
     CPDF_Dictionary* pAnnotDic = ObjectArray.GetAt(i);
     if (!pAnnotDic)
       continue;
 
-    CFX_FloatRect rcAnnot = pAnnotDic->GetRectBy("Rect");
+    CFX_FloatRect rcAnnot = pAnnotDic->GetRectFor("Rect");
     rcAnnot.Normalize();
 
-    CFX_ByteString sAnnotState = pAnnotDic->GetStringBy("AS");
-    CPDF_Dictionary* pAnnotAP = pAnnotDic->GetDictBy("AP");
+    CFX_ByteString sAnnotState = pAnnotDic->GetStringFor("AS");
+    CPDF_Dictionary* pAnnotAP = pAnnotDic->GetDictFor("AP");
     if (!pAnnotAP)
       continue;
 
-    CPDF_Stream* pAPStream = pAnnotAP->GetStreamBy("N");
+    CPDF_Stream* pAPStream = pAnnotAP->GetStreamFor("N");
     if (!pAPStream) {
-      CPDF_Dictionary* pAPDic = pAnnotAP->GetDictBy("N");
+      CPDF_Dictionary* pAPDic = pAnnotAP->GetDictFor("N");
       if (!pAPDic)
         continue;
 
       if (!sAnnotState.IsEmpty()) {
-        pAPStream = pAPDic->GetStreamBy(sAnnotState);
+        pAPStream = pAPDic->GetStreamFor(sAnnotState);
       } else {
         auto it = pAPDic->begin();
         if (it != pAPDic->end()) {
           CPDF_Object* pFirstObj = it->second;
           if (pFirstObj) {
             if (pFirstObj->IsReference())
               pFirstObj = pFirstObj->GetDirect();
             if (!pFirstObj->IsStream())
               continue;
             pAPStream = pFirstObj->AsStream();
           }
         }
       }
     }
     if (!pAPStream)
       continue;
 
     CPDF_Dictionary* pAPDic = pAPStream->GetDict();
-    CFX_Matrix matrix = pAPDic->GetMatrixBy("Matrix");
+    CFX_Matrix matrix = pAPDic->GetMatrixFor("Matrix");
 
     CFX_FloatRect rcStream;
     if (pAPDic->KeyExist("Rect"))
-      rcStream = pAPDic->GetRectBy("Rect");
+      rcStream = pAPDic->GetRectFor("Rect");
     else if (pAPDic->KeyExist("BBox"))
-      rcStream = pAPDic->GetRectBy("BBox");
+      rcStream = pAPDic->GetRectFor("BBox");
 
     if (rcStream.IsEmpty())
       continue;
 
     CPDF_Object* pObj = pAPStream;
 
     if (pObj) {
       CPDF_Dictionary* pObjDic = pObj->GetDict();
       if (pObjDic) {
-        pObjDic->SetAtName("Type", "XObject");
-        pObjDic->SetAtName("Subtype", "Form");
+        pObjDic->SetNameFor("Type", "XObject");
+        pObjDic->SetNameFor("Subtype", "Form");
       }
     }
 
-    CPDF_Dictionary* pXObject = pNewXORes->GetDictBy("XObject");
+    CPDF_Dictionary* pXObject = pNewXORes->GetDictFor("XObject");
     if (!pXObject) {
       pXObject = new CPDF_Dictionary;
-      pNewXORes->SetAt("XObject", pXObject);
+      pNewXORes->SetFor("XObject", pXObject);
     }
 
     CFX_ByteString sFormName;
     sFormName.Format("F%d", i);
     uint32_t dwStreamObjNum = pDocument->AddIndirectObject(pObj);
-    pXObject->SetAtReference(sFormName, pDocument, dwStreamObjNum);
+    pXObject->SetReferenceFor(sFormName, pDocument, dwStreamObjNum);
 
     CPDF_StreamAcc acc;
     acc.LoadAllData(pNewXObject);
 
     const uint8_t* pData = acc.GetData();
     CFX_ByteString sStream(pData, acc.GetSize());
     CFX_ByteString sTemp;
 
     if (matrix.IsIdentity()) {
       matrix.a = 1.0f;
       matrix.b = 0.0f;
       matrix.c = 0.0f;
       matrix.d = 1.0f;
       matrix.e = 0.0f;
       matrix.f = 0.0f;
     }
 
     CFX_Matrix m = GetMatrix(rcAnnot, rcStream, matrix);
     sTemp.Format("q %f 0 0 %f %f %f cm /%s Do Q\n", m.a, m.d, m.e, m.f,
                  sFormName.c_str());
     sStream += sTemp;
     pNewXObject->SetData(sStream.raw_str(), sStream.GetLength(), FALSE, FALSE);
   }
-  pPageDict->RemoveAt("Annots");
+  pPageDict->RemoveFor("Annots");
 
   ObjectArray.RemoveAll();
   RectArray.RemoveAll();
 
   return FLATTEN_SUCCESS;
 }