Rename dictionary set and get methods

core/fpdfdoc/cpdf_formfield.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfdoc/include/cpdf_formfield.h"
 
 #include <set>
 
@@ skipping 38 matching lines @@
 }  // namespace
 
 CPDF_Object* FPDF_GetFieldAttr(CPDF_Dictionary* pFieldDict,
                                const FX_CHAR* name,
                                int nLevel) {
   if (nLevel > kMaxRecursion)
     return nullptr;
   if (!pFieldDict)
     return nullptr;
 
-  CPDF_Object* pAttr = pFieldDict->GetDirectObjectBy(name);
+  CPDF_Object* pAttr = pFieldDict->GetDirectObjectFor(name);
   if (pAttr)
     return pAttr;
 
-  CPDF_Dictionary* pParent = pFieldDict->GetDictBy("Parent");
+  CPDF_Dictionary* pParent = pFieldDict->GetDictFor("Parent");
   if (!pParent)
     return nullptr;
   return FPDF_GetFieldAttr(pParent, name, nLevel + 1);
 }
 
 CFX_WideString FPDF_GetFullName(CPDF_Dictionary* pFieldDict) {
   CFX_WideString full_name;
   std::set<CPDF_Dictionary*> visited;
   CPDF_Dictionary* pLevel = pFieldDict;
   while (pLevel) {
     visited.insert(pLevel);
-    CFX_WideString short_name = pLevel->GetUnicodeTextBy("T");
+    CFX_WideString short_name = pLevel->GetUnicodeTextFor("T");
     if (!short_name.IsEmpty()) {
       if (full_name.IsEmpty())
         full_name = short_name;
       else
         full_name = short_name + L"." + full_name;
     }
-    pLevel = pLevel->GetDictBy("Parent");
+    pLevel = pLevel->GetDictFor("Parent");
     if (pdfium::ContainsKey(visited, pLevel))
       break;
   }
   return full_name;
 }
 
 CPDF_FormField::CPDF_FormField(CPDF_InterForm* pForm, CPDF_Dictionary* pDict)
     : m_Type(Unknown),
       m_pForm(pForm),
       m_pDict(pDict),
@@ skipping 123 matching lines @@
         return FALSE;
 
       if (bNotify && !NotifyBeforeValueChange(csDValue))
         return FALSE;
 
       if (pDV) {
         CPDF_Object* pClone = pDV->Clone();
         if (!pClone)
           return FALSE;
 
-        m_pDict->SetAt("V", pClone);
+        m_pDict->SetFor("V", pClone);
         if (pRV) {
           CPDF_Object* pCloneR = pDV->Clone();
-          m_pDict->SetAt("RV", pCloneR);
+          m_pDict->SetFor("RV", pCloneR);
         }
       } else {
-        m_pDict->RemoveAt("V");
-        m_pDict->RemoveAt("RV");
+        m_pDict->RemoveFor("V");
+        m_pDict->RemoveFor("RV");
       }
       if (bNotify)
         NotifyAfterValueChange();
       break;
     }
   }
   return TRUE;
 }
 
 int CPDF_FormField::GetControlIndex(const CPDF_FormControl* pControl) const {
@@ skipping 113 matching lines @@
     case RichText:
     case Text:
     case ComboBox: {
       CFX_WideString csValue = value;
       if (bNotify && !NotifyBeforeValueChange(csValue))
         return FALSE;
 
       int iIndex = FindOptionValue(csValue);
       if (iIndex < 0) {
         CFX_ByteString bsEncodeText = PDF_EncodeText(csValue);
-        m_pDict->SetAtString(bDefault ? "DV" : "V", bsEncodeText);
+        m_pDict->SetStringFor(bDefault ? "DV" : "V", bsEncodeText);
         if (m_Type == RichText && !bDefault)
-          m_pDict->SetAtString("RV", bsEncodeText);
-        m_pDict->RemoveAt("I");
+          m_pDict->SetStringFor("RV", bsEncodeText);
+        m_pDict->RemoveFor("I");
       } else {
-        m_pDict->SetAtString(bDefault ? "DV" : "V", PDF_EncodeText(csValue));
+        m_pDict->SetStringFor(bDefault ? "DV" : "V", PDF_EncodeText(csValue));
         if (!bDefault) {
           ClearSelection();
           SetItemSelection(iIndex, TRUE);
         }
       }
       if (bNotify)
         NotifyAfterValueChange();
       break;
     }
     case ListBox: {
@@ skipping 29 matching lines @@
   if (CPDF_Object* pObj = FPDF_GetFieldAttr(m_pDict, "MaxLen"))
     return pObj->GetInteger();
 
   for (int i = 0; i < m_ControlList.GetSize(); i++) {
     CPDF_FormControl* pControl = m_ControlList.GetAt(i);
     if (!pControl)
       continue;
 
     CPDF_Dictionary* pWidgetDict = pControl->m_pWidgetDict;
     if (pWidgetDict->KeyExist("MaxLen"))
-      return pWidgetDict->GetIntegerBy("MaxLen");
+      return pWidgetDict->GetIntegerFor("MaxLen");
   }
   return 0;
 }
 
 int CPDF_FormField::CountSelectedItems() const {
   CPDF_Object* pValue = FPDF_GetFieldAttr(m_pDict, "V");
   if (!pValue) {
     pValue = FPDF_GetFieldAttr(m_pDict, "I");
     if (!pValue)
       return 0;
@@ skipping 46 matching lines @@
 FX_BOOL CPDF_FormField::ClearSelection(FX_BOOL bNotify) {
   if (bNotify && m_pForm->m_pFormNotify) {
     CFX_WideString csValue;
     int iIndex = GetSelectedIndex(0);
     if (iIndex >= 0)
       csValue = GetOptionLabel(iIndex);
 
     if (!NotifyListOrComboBoxBeforeChange(csValue))
       return FALSE;
   }
-  m_pDict->RemoveAt("V");
-  m_pDict->RemoveAt("I");
+  m_pDict->RemoveFor("V");
+  m_pDict->RemoveFor("I");
   if (bNotify)
     NotifyListOrComboBoxAfterChange();
   return TRUE;
 }
 
 FX_BOOL CPDF_FormField::IsItemSelected(int index) const {
   ASSERT(GetType() == ComboBox || GetType() == ListBox);
   if (index < 0 || index >= CountOptions())
     return FALSE;
   if (IsOptionSelected(index))
@@ skipping 43 matching lines @@
     return FALSE;
 
   CFX_WideString opt_value = GetOptionValue(index);
   if (bNotify && !NotifyListOrComboBoxBeforeChange(opt_value))
     return FALSE;
 
   if (bSelected) {
     if (GetType() == ListBox) {
       SelectOption(index, TRUE);
       if (!(m_Flags & kFormListMultiSelect)) {
-        m_pDict->SetAtString("V", PDF_EncodeText(opt_value));
+        m_pDict->SetStringFor("V", PDF_EncodeText(opt_value));
       } else {
         CPDF_Array* pArray = new CPDF_Array;
         for (int i = 0; i < CountOptions(); i++) {
           if (i == index || IsItemSelected(i)) {
             opt_value = GetOptionValue(i);
             pArray->AddString(PDF_EncodeText(opt_value));
           }
         }
-        m_pDict->SetAt("V", pArray);
+        m_pDict->SetFor("V", pArray);
       }
     } else {
-      m_pDict->SetAtString("V", PDF_EncodeText(opt_value));
+      m_pDict->SetStringFor("V", PDF_EncodeText(opt_value));
       CPDF_Array* pI = new CPDF_Array;
       pI->AddInteger(index);
-      m_pDict->SetAt("I", pI);
+      m_pDict->SetFor("I", pI);
     }
   } else {
     CPDF_Object* pValue = FPDF_GetFieldAttr(m_pDict, "V");
     if (pValue) {
       if (GetType() == ListBox) {
         SelectOption(index, FALSE);
         if (pValue->IsString()) {
           if (pValue->GetUnicodeText() == opt_value)
-            m_pDict->RemoveAt("V");
+            m_pDict->RemoveFor("V");
         } else if (pValue->IsArray()) {
           CPDF_Array* pArray = new CPDF_Array;
           for (int i = 0; i < CountOptions(); i++) {
             if (i != index && IsItemSelected(i)) {
               opt_value = GetOptionValue(i);
               pArray->AddString(PDF_EncodeText(opt_value));
             }
           }
           if (pArray->GetCount() < 1)
             pArray->Release();
           else
-            m_pDict->SetAt("V", pArray);
+            m_pDict->SetFor("V", pArray);
         }
       } else {
-        m_pDict->RemoveAt("V");
-        m_pDict->RemoveAt("I");
+        m_pDict->RemoveFor("V");
+        m_pDict->RemoveFor("I");
       }
     }
   }
   if (bNotify)
     NotifyListOrComboBoxAfterChange();
   return TRUE;
 }
 
 FX_BOOL CPDF_FormField::IsItemDefaultSelected(int index) const {
   ASSERT(GetType() == ComboBox || GetType() == ListBox);
@@ skipping 71 matching lines @@
 
   if (bNotify && !NotifyListOrComboBoxBeforeChange(csOptLabel))
     return -1;
 
   CFX_ByteString csStr =
       PDF_EncodeText(csOptLabel.c_str(), csOptLabel.GetLength());
   CPDF_Object* pValue = FPDF_GetFieldAttr(m_pDict, "Opt");
   CPDF_Array* pOpt = ToArray(pValue);
   if (!pOpt) {
     pOpt = new CPDF_Array;
-    m_pDict->SetAt("Opt", pOpt);
+    m_pDict->SetFor("Opt", pOpt);
   }
 
   int iCount = pdfium::base::checked_cast<int, size_t>(pOpt->GetCount());
   if (index >= iCount) {
     pOpt->AddString(csStr);
     index = iCount;
   } else {
     CPDF_String* pString = new CPDF_String(csStr, FALSE);
     pOpt->InsertAt(index, pString);
   }
 
   if (bNotify)
     NotifyListOrComboBoxAfterChange();
   return index;
 }
 
 FX_BOOL CPDF_FormField::ClearOptions(FX_BOOL bNotify) {
   if (bNotify && m_pForm->m_pFormNotify) {
     CFX_WideString csValue;
     int iIndex = GetSelectedIndex(0);
     if (iIndex >= 0)
       csValue = GetOptionLabel(iIndex);
     if (!NotifyListOrComboBoxBeforeChange(csValue))
       return FALSE;
   }
 
-  m_pDict->RemoveAt("Opt");
-  m_pDict->RemoveAt("V");
-  m_pDict->RemoveAt("DV");
-  m_pDict->RemoveAt("I");
-  m_pDict->RemoveAt("TI");
+  m_pDict->RemoveFor("Opt");
+  m_pDict->RemoveFor("V");
+  m_pDict->RemoveFor("DV");
+  m_pDict->RemoveFor("I");
+  m_pDict->RemoveFor("TI");
 
   if (bNotify)
     NotifyListOrComboBoxAfterChange();
 
   return TRUE;
 }
 #endif  // PDF_ENABLE_XFA
 
 FX_BOOL CPDF_FormField::CheckControl(int iControlIndex,
                                      bool bChecked,
@@ skipping 25 matching lines @@
       if (i == iControlIndex)
         pCtrl->CheckControl(bChecked);
       else if (bChecked)
         pCtrl->CheckControl(FALSE);
     }
   }
 
   CPDF_Object* pOpt = FPDF_GetFieldAttr(m_pDict, "Opt");
   if (!ToArray(pOpt)) {
     if (bChecked) {
-      m_pDict->SetAtName("V", csBExport);
+      m_pDict->SetNameFor("V", csBExport);
     } else {
       CFX_ByteString csV;
       CPDF_Object* pV = FPDF_GetFieldAttr(m_pDict, "V");
       if (pV)
         csV = pV->GetString();
       if (csV == csBExport)
-        m_pDict->SetAtName("V", "Off");
+        m_pDict->SetNameFor("V", "Off");
     }
   } else if (bChecked) {
     CFX_ByteString csIndex;
     csIndex.Format("%d", iControlIndex);
-    m_pDict->SetAtName("V", csIndex);
+    m_pDict->SetNameFor("V", csIndex);
   }
   if (bNotify && m_pForm->m_pFormNotify)
     m_pForm->m_pFormNotify->AfterCheckedStatusChange(this);
   return TRUE;
 }
 
 CFX_WideString CPDF_FormField::GetCheckValue(FX_BOOL bDefault) const {
   ASSERT(GetType() == CheckBox || GetType() == RadioButton);
   CFX_WideString csExport = L"Off";
   int iCount = CountControls();
@@ skipping 57 matching lines @@
   for (CPDF_Object* pObj : *pArray) {
     if (pObj->GetInteger() == iOptIndex)
       return TRUE;
   }
   return FALSE;
 }
 
 FX_BOOL CPDF_FormField::SelectOption(int iOptIndex,
                                      FX_BOOL bSelected,
                                      FX_BOOL bNotify) {
-  CPDF_Array* pArray = m_pDict->GetArrayBy("I");
+  CPDF_Array* pArray = m_pDict->GetArrayFor("I");
   if (!pArray) {
     if (!bSelected)
       return TRUE;
 
     pArray = new CPDF_Array;
-    m_pDict->SetAt("I", pArray);
+    m_pDict->SetFor("I", pArray);
   }
 
   FX_BOOL bReturn = FALSE;
   for (size_t i = 0; i < pArray->GetCount(); i++) {
     int iFind = pArray->GetIntegerAt(i);
     if (iFind == iOptIndex) {
       if (bSelected)
         return TRUE;
 
       if (bNotify && m_pForm->m_pFormNotify) {
@@ skipping 18 matching lines @@
       pArray->InsertAt(i, new CPDF_Number(iOptIndex));
       bReturn = TRUE;
       break;
     }
   }
   if (!bReturn) {
     if (bSelected)
       pArray->AddInteger(iOptIndex);
 
     if (pArray->IsEmpty())
-      m_pDict->RemoveAt("I");
+      m_pDict->RemoveFor("I");
   }
   if (bNotify)
     NotifyListOrComboBoxAfterChange();
 
   return TRUE;
 }
 
 FX_BOOL CPDF_FormField::ClearSelectedOptions(FX_BOOL bNotify) {
   if (bNotify && m_pForm->m_pFormNotify) {
     CFX_WideString csValue;
     int iIndex = GetSelectedIndex(0);
     if (iIndex >= 0)
       csValue = GetOptionLabel(iIndex);
 
     if (!NotifyListOrComboBoxBeforeChange(csValue))
       return FALSE;
   }
-  m_pDict->RemoveAt("I");
+  m_pDict->RemoveFor("I");
   if (bNotify)
     NotifyListOrComboBoxAfterChange();
 
   return TRUE;
 }
 
 void CPDF_FormField::LoadDA() {
   CPDF_Dictionary* pFormDict = m_pForm->m_pFormDict;
   if (!pFormDict)
     return;
 
   CFX_ByteString DA;
   if (CPDF_Object* pObj = FPDF_GetFieldAttr(m_pDict, "DA"))
     DA = pObj->GetString();
 
   if (DA.IsEmpty())
-    DA = pFormDict->GetStringBy("DA");
+    DA = pFormDict->GetStringFor("DA");
 
   if (DA.IsEmpty())
     return;
 
-  CPDF_Dictionary* pDR = pFormDict->GetDictBy("DR");
+  CPDF_Dictionary* pDR = pFormDict->GetDictFor("DR");
   if (!pDR)
     return;
 
-  CPDF_Dictionary* pFont = pDR->GetDictBy("Font");
+  CPDF_Dictionary* pFont = pDR->GetDictFor("Font");
   if (!pFont)
     return;
 
   CPDF_SimpleParser syntax(DA.AsStringC());
   syntax.FindTagParamFromStart("Tf", 2);
   CFX_ByteString font_name(syntax.GetWord());
-  CPDF_Dictionary* pFontDict = pFont->GetDictBy(font_name);
+  CPDF_Dictionary* pFontDict = pFont->GetDictFor(font_name);
   if (!pFontDict)
     return;
 
   m_pFont = m_pForm->m_pDocument->LoadFont(pFontDict);
   m_FontSize = FX_atof(syntax.GetWord());
 }
 
 bool CPDF_FormField::NotifyBeforeSelectionChange(const CFX_WideString& value) {
   if (!m_pForm->m_pFormNotify)
     return true;
@@ skipping 35 matching lines @@
     case ListBox:
       NotifyAfterSelectionChange();
       break;
     case ComboBox:
       NotifyAfterValueChange();
       break;
     default:
       break;
   }
 }