Clarify a role of Shadow DOM related functions

Clarify a role of Shadow DOM related functions

ElementShadow's member functions, and other functions, are still confusing.
It is not clearly demonstrated that each function is for v0 or v1.

This CL makes it clear by:

- Adding DCHECK()
- Rename function names
- Check whether v0 or v1 in caller sides

This CL is a preparation for further ElementShadow's refactoring.

BUG=624724
Committed: https://crrev.com/ab06a2848c7ed182395652221a8063e6df583b25
Cr-Commit-Position: refs/heads/master@{#418178}

[hayato, 2016-09-09 05:48:36]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 05:48:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-09-09 05:55:07]

clarify

[hayato, 2016-09-09 05:55:09]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 05:55:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-09-09 06:06:08]

Description was changed from

==========
Clarify each role of ElementShadow's member functions
==========

to

==========
Clarify a role of Shadow DOM related functions

ElementShadow's member functions, and other functions, are still confusing.
It is not clearly demonstrated that each function is for v0 or v1.

This CL makes it clear by:

- Adding DCHECK()
- Rename function names
- Check whether v0 or v1 in caller sides

This CL is preparation of further refactoring ElementShadow.
==========

[hayato, 2016-09-09 06:06:49]

Description was changed from

==========
Clarify a role of Shadow DOM related functions

ElementShadow's member functions, and other functions, are still confusing.
It is not clearly demonstrated that each function is for v0 or v1.

This CL makes it clear by:

- Adding DCHECK()
- Rename function names
- Check whether v0 or v1 in caller sides

This CL is preparation of further refactoring ElementShadow.
==========

to

==========
Clarify a role of Shadow DOM related functions

ElementShadow's member functions, and other functions, are still confusing.
It is not clearly demonstrated that each function is for v0 or v1.

This CL makes it clear by:

- Adding DCHECK()
- Rename function names
- Check whether v0 or v1 in caller sides

This CL is a preparation for further ElementShadow's refactoring.
==========

[hayato, 2016-09-09 06:07:12]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2016-09-09 06:07:12]

PTAL

[commit-bot: I haz the power, 2016-09-09 06:34:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 06:34:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[kochi, 2016-09-09 06:51:06]

https://codereview.chromium.org/2323953003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/ElementShadow.h (right):

https://codereview.chromium.org/2323953003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/ElementShadow.h:73: 
nit: Why not adding "V0" or "ForV0" for these functions?

https://codereview.chromium.org/2323953003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLContentElement.cpp (right):

https://codereview.chromium.org/2323953003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLContentElement.cpp:79: if (!root->isV1()
&& root->owner())
If <content> is in V1 shadow, we don't have to parser select= attribute at all?

i.e.

ShadowRoot* root = containingShadowRoot();

if (!root || root->isV1 || name != selectAttr) {
    InsertionPoint::parseAttribute(...);
    return;
}

// do the rest

[hayato, 2016-09-09 07:03:29]

https://codereview.chromium.org/2323953003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/ElementShadow.h (right):

https://codereview.chromium.org/2323953003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/ElementShadow.h:73: 
I won't it now. That can be considered at further refactoring.

https://codereview.chromium.org/2323953003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLContentElement.cpp (right):

https://codereview.chromium.org/2323953003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLContentElement.cpp:79: if (!root->isV1()
&& root->owner())
Yeah, I am aware there are still a lot of TODO things.
I'll address them in bunch of follow-up CLs.

[kochi, 2016-09-09 07:06:58]

lgtm

https://codereview.chromium.org/2323953003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLContentElement.cpp (right):

https://codereview.chromium.org/2323953003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLContentElement.cpp:79: if (!root->isV1()
&& root->owner())
On 2016/09/09 07:03:29, hayato wrote:
> Yeah, I am aware there are still a lot of TODO things.
> I'll address them in bunch of follow-up CLs.

Sounds good.

[hayato, 2016-09-09 07:16:30]

rebased

[hayato, 2016-09-09 07:16:32]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 07:16:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-09-09 07:16:44]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-09-09 07:16:47]

The CQ bit was checked by hayato@chromium.org

[hayato, 2016-09-09 07:16:47]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/2323953003/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2016-09-09 07:17:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 07:17:04]

This CL has an open dependency (Issue 2327743002 Patch 20001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[hayato, 2016-09-09 09:47:32]

Description was changed from

==========
Clarify a role of Shadow DOM related functions

ElementShadow's member functions, and other functions, are still confusing.
It is not clearly demonstrated that each function is for v0 or v1.

This CL makes it clear by:

- Adding DCHECK()
- Rename function names
- Check whether v0 or v1 in caller sides

This CL is a preparation for further ElementShadow's refactoring.
==========

to

==========
Clarify a role of Shadow DOM related functions

ElementShadow's member functions, and other functions, are still confusing.
It is not clearly demonstrated that each function is for v0 or v1.

This CL makes it clear by:

- Adding DCHECK()
- Rename function names
- Check whether v0 or v1 in caller sides

This CL is a preparation for further ElementShadow's refactoring.

BUG=624724
==========

[hayato, 2016-09-13 04:17:08]

rebased

[hayato, 2016-09-13 04:17:09]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-09-13 04:17:17]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-09-13 04:17:21]

The CQ bit was checked by hayato@chromium.org

[hayato, 2016-09-13 04:17:21]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/2323953003/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2016-09-13 04:17:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 05:44:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-13 05:46:56]

Description was changed from

==========
Clarify a role of Shadow DOM related functions

ElementShadow's member functions, and other functions, are still confusing.
It is not clearly demonstrated that each function is for v0 or v1.

This CL makes it clear by:

- Adding DCHECK()
- Rename function names
- Check whether v0 or v1 in caller sides

This CL is a preparation for further ElementShadow's refactoring.

BUG=624724
==========

to

==========
Clarify a role of Shadow DOM related functions

ElementShadow's member functions, and other functions, are still confusing.
It is not clearly demonstrated that each function is for v0 or v1.

This CL makes it clear by:

- Adding DCHECK()
- Rename function names
- Check whether v0 or v1 in caller sides

This CL is a preparation for further ElementShadow's refactoring.

BUG=624724

Committed: https://crrev.com/ab06a2848c7ed182395652221a8063e6df583b25
Cr-Commit-Position: refs/heads/master@{#418178}
==========

[commit-bot: I haz the power, 2016-09-13 05:46:57]

Patchset 4 (id:??) landed as
https://crrev.com/ab06a2848c7ed182395652221a8063e6df583b25
Cr-Commit-Position: refs/heads/master@{#418178}