third_party/WebKit/Source/core/dom/shadow/InsertionPoint.h - Issue 2323953003: Clarify a role of Shadow DOM related functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/InsertionPoint.h

Issue 2323953003: Clarify a role of Shadow DOM related functions (Closed)

Patch Set: rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/shadow/InsertionPoint.h

diff --git a/third_party/WebKit/Source/core/dom/shadow/InsertionPoint.h b/third_party/WebKit/Source/core/dom/shadow/InsertionPoint.h

index ca396d07ae506433fb0db5bf839291f7b01ebaf2..63437c5164702a7e273f917b190d34c7763057a8 100644

--- a/third_party/WebKit/Source/core/dom/shadow/InsertionPoint.h

+++ b/third_party/WebKit/Source/core/dom/shadow/InsertionPoint.h

@@ -97,8 +97,7 @@ inline bool isActiveShadowInsertionPoint(const Node& node)

return node.isInsertionPoint() && toInsertionPoint(node).isShadowInsertionPoint();

}

-// TODO(hayato): The function name is confusing. This neither resolve a reprojection nor support v1 shadow trees.

-inline ElementShadow* shadowWhereNodeCanBeDistributed(const Node& node)

+inline ElementShadow* shadowWhereNodeCanBeDistributedForV0(const Node& node)

{

Node* parent = node.parentNode();

if (!parent)