Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

Issue 2323953003: Clarify a role of Shadow DOM related functions (Closed)
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/shadow/ElementShadow.h
diff --git a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h
index 57050d2b879081988233dce903be7161fbec677c..3a4fbb1fd402a8c5b3f52b4ab99e2a53479e8e1d 100644
--- a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h
+++ b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h
@@ -55,21 +55,22 @@ public:
void attach(const Node::AttachContext&);
void detach(const Node::AttachContext&);
- void willAffectSelector();
- const SelectRuleFeatureSet& ensureSelectFeatureSet();
-
void distributeIfNeeded();
void setNeedsDistributionRecalc();
bool needsDistributionRecalc() const { return m_needsDistributionRecalc; }
+ bool isV1() const { return youngestShadowRoot().isV1(); };
+ bool isOpenOrV0() const { return youngestShadowRoot().isOpenOrV0(); };
+
+ // For only v0
+ void willAffectSelector();
+ const SelectRuleFeatureSet& ensureSelectFeatureSet();
+
const InsertionPoint* finalDestinationInsertionPointFor(const Node*) const;
const DestinationInsertionPoints* destinationInsertionPointsFor(const Node*) const;
void didDistributeNode(const Node*, InsertionPoint*);
- bool isV1() const { return youngestShadowRoot().isV1(); };
- bool isOpenOrV0() const { return youngestShadowRoot().isOpenOrV0(); };
-
DECLARE_TRACE();
DECLARE_TRACE_WRAPPERS();
@@ -79,7 +80,7 @@ private:
void appendShadowRoot(ShadowRoot&);
void distribute();
- void clearDistribution();
+ void clearDistributionV0();
void distributeV0();
void distributeV1();
@@ -90,12 +91,13 @@ private:
bool needsSelectFeatureSet() const { return m_needsSelectFeatureSet; }
void setNeedsSelectFeatureSet() { m_needsSelectFeatureSet = true; }
+ Member<ShadowRoot> m_shadowRoot;
+ bool m_needsDistributionRecalc;
+
+ // For only v0
using NodeToDestinationInsertionPoints = HeapHashMap<Member<const Node>, Member<DestinationInsertionPoints>>;
NodeToDestinationInsertionPoints m_nodeToInsertionPoints;
-
SelectRuleFeatureSet m_selectFeatures;
- Member<ShadowRoot> m_shadowRoot;
- bool m_needsDistributionRecalc;
bool m_needsSelectFeatureSet;
};
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698