Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp

Issue 2323953003: Clarify a role of Shadow DOM related functions (Closed)
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp
diff --git a/third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp b/third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp
index 3403cf8a33463a9fe8237a128eb166b5c59c0459..efbda97fe25055fcf81b3700b0b79896bc4606b2 100644
--- a/third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp
+++ b/third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp
@@ -265,8 +265,8 @@ const InsertionPoint* resolveReprojection(const Node* projectedNode)
const Node* current = projectedNode;
ElementShadow* lastElementShadow = 0;
while (true) {
- ElementShadow* shadow = shadowWhereNodeCanBeDistributed(*current);
- if (!shadow || shadow == lastElementShadow)
+ ElementShadow* shadow = shadowWhereNodeCanBeDistributedForV0(*current);
+ if (!shadow || shadow->isV1() || shadow == lastElementShadow)
break;
lastElementShadow = shadow;
const InsertionPoint* insertedTo = shadow->finalDestinationInsertionPointFor(projectedNode);
@@ -284,8 +284,8 @@ void collectDestinationInsertionPoints(const Node& node, HeapVector<Member<Inser
const Node* current = &node;
ElementShadow* lastElementShadow = 0;
while (true) {
- ElementShadow* shadow = shadowWhereNodeCanBeDistributed(*current);
- if (!shadow || shadow == lastElementShadow)
+ ElementShadow* shadow = shadowWhereNodeCanBeDistributedForV0(*current);
+ if (!shadow || shadow->isV1() || shadow == lastElementShadow)
return;
lastElementShadow = shadow;
const DestinationInsertionPoints* insertionPoints = shadow->destinationInsertionPointsFor(&node);
« no previous file with comments | « third_party/WebKit/Source/core/dom/shadow/InsertionPoint.h ('k') | third_party/WebKit/Source/core/html/HTMLContentElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698