Clarify a role of Shadow DOM related functions

third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Neither the name of Google Inc. nor the names of its
@@ skipping 37 matching lines @@
     ShadowRoot* oldestShadowRoot() const { return m_shadowRoot; }
     ElementShadow* containingShadow() const;
 
     ShadowRoot& addShadowRoot(Element& shadowHost, ShadowRootType);
 
     bool hasSameStyles(const ElementShadow*) const;
 
     void attach(const Node::AttachContext&);
     void detach(const Node::AttachContext&);
 
-    void willAffectSelector();
-    const SelectRuleFeatureSet& ensureSelectFeatureSet();
-
     void distributeIfNeeded();
     void setNeedsDistributionRecalc();
     bool needsDistributionRecalc() const { return m_needsDistributionRecalc; }
 
+    bool isV1() const { return youngestShadowRoot().isV1(); };
+    bool isOpenOrV0() const { return youngestShadowRoot().isOpenOrV0(); };
+
+    // For only v0
+    void willAffectSelector();
+    const SelectRuleFeatureSet& ensureSelectFeatureSet();
+
     const InsertionPoint* finalDestinationInsertionPointFor(const Node*) const;
     const DestinationInsertionPoints* destinationInsertionPointsFor(const Node*) const;
 
     void didDistributeNode(const Node*, InsertionPoint*);
 

[kochi, 2016/09/09 06:51:06]

nit: Why not adding "V0" or "ForV0" for these functions?

[hayato, 2016/09/09 07:03:28]

I won't it now. That can be considered at further refactoring.

-    bool isV1() const { return youngestShadowRoot().isV1(); };
-    bool isOpenOrV0() const { return youngestShadowRoot().isOpenOrV0(); };
-
     DECLARE_TRACE();
     DECLARE_TRACE_WRAPPERS();
 
 private:
     ElementShadow();
 
     void appendShadowRoot(ShadowRoot&);
 
     void distribute();
-    void clearDistribution();
+    void clearDistributionV0();
 
     void distributeV0();
     void distributeV1();
 
     void collectSelectFeatureSetFrom(ShadowRoot&);
     void distributeNodeChildrenTo(InsertionPoint*, ContainerNode*);
 
     bool needsSelectFeatureSet() const { return m_needsSelectFeatureSet; }
     void setNeedsSelectFeatureSet() { m_needsSelectFeatureSet = true; }
 
+    Member<ShadowRoot> m_shadowRoot;
+    bool m_needsDistributionRecalc;
+
+    // For only v0
     using NodeToDestinationInsertionPoints = HeapHashMap<Member<const Node>, Member<DestinationInsertionPoints>>;
     NodeToDestinationInsertionPoints m_nodeToInsertionPoints;
-
     SelectRuleFeatureSet m_selectFeatures;
-    Member<ShadowRoot> m_shadowRoot;
-    bool m_needsDistributionRecalc;
     bool m_needsSelectFeatureSet;
 };
 
 inline Element& ElementShadow::host() const
 {
     DCHECK(m_shadowRoot);
     return m_shadowRoot->host();
 }
 
 inline ShadowRoot* Node::youngestShadowRoot() const
@@ skipping 20 matching lines @@
 inline void ElementShadow::distributeIfNeeded()
 {
     if (m_needsDistributionRecalc)
         distribute();
     m_needsDistributionRecalc = false;
 }
 
 } // namespace blink
 
 #endif