Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLContentElement.cpp

Issue 2323953003: Clarify a role of Shadow DOM related functions (Closed)
Patch Set: clarify Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Neither the name of Google Inc. nor the names of its 10 * * Neither the name of Google Inc. nor the names of its
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 m_shouldParseSelect = false; 69 m_shouldParseSelect = false;
70 m_isValidSelector = validateSelect(); 70 m_isValidSelector = validateSelect();
71 if (!m_isValidSelector) 71 if (!m_isValidSelector)
72 m_selectorList = CSSSelectorList(); 72 m_selectorList = CSSSelectorList();
73 } 73 }
74 74
75 void HTMLContentElement::parseAttribute(const QualifiedName& name, const AtomicS tring& oldValue, const AtomicString& value) 75 void HTMLContentElement::parseAttribute(const QualifiedName& name, const AtomicS tring& oldValue, const AtomicString& value)
76 { 76 {
77 if (name == selectAttr) { 77 if (name == selectAttr) {
78 if (ShadowRoot* root = containingShadowRoot()) { 78 if (ShadowRoot* root = containingShadowRoot()) {
79 if (root->owner()) 79 if (!root->isV1() && root->owner())
kochi 2016/09/09 06:51:06 If <content> is in V1 shadow, we don't have to par
hayato 2016/09/09 07:03:29 Yeah, I am aware there are still a lot of TODO thi
kochi 2016/09/09 07:06:58 Sounds good.
80 root->owner()->willAffectSelector(); 80 root->owner()->willAffectSelector();
81 } 81 }
82 m_shouldParseSelect = true; 82 m_shouldParseSelect = true;
83 m_select = value; 83 m_select = value;
84 } else { 84 } else {
85 InsertionPoint::parseAttribute(name, oldValue, value); 85 InsertionPoint::parseAttribute(name, oldValue, value);
86 } 86 }
87 } 87 }
88 88
89 static inline bool includesDisallowedPseudoClass(const CSSSelector& selector) 89 static inline bool includesDisallowedPseudoClass(const CSSSelector& selector)
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
127 SelectorChecker::SelectorCheckingContext context(&element, SelectorChecker:: VisitedMatchDisabled); 127 SelectorChecker::SelectorCheckingContext context(&element, SelectorChecker:: VisitedMatchDisabled);
128 for (const CSSSelector* selector = selectorList().first(); selector; selecto r = CSSSelectorList::next(*selector)) { 128 for (const CSSSelector* selector = selectorList().first(); selector; selecto r = CSSSelectorList::next(*selector)) {
129 context.selector = selector; 129 context.selector = selector;
130 if (checker.match(context)) 130 if (checker.match(context))
131 return true; 131 return true;
132 } 132 }
133 return false; 133 return false;
134 } 134 }
135 135
136 } // namespace blink 136 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698