Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2323953003: Clarify a role of Shadow DOM related functions (Closed)
Patch Set: rebased Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/shadow/ElementShadow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Element.cpp
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp
index 71773b8257082eb9f7765e35561721991944fdc1..0f897b6a16c9f0a0c9fb0593279cf633a9a6d970 100644
--- a/third_party/WebKit/Source/core/dom/Element.cpp
+++ b/third_party/WebKit/Source/core/dom/Element.cpp
@@ -1173,7 +1173,7 @@ static inline AtomicString makeIdForStyleResolution(const AtomicString& value, b
void Element::attributeChanged(const QualifiedName& name, const AtomicString& oldValue, const AtomicString& newValue, AttributeModificationReason reason)
{
- if (ElementShadow* parentElementShadow = shadowWhereNodeCanBeDistributed(*this)) {
+ if (ElementShadow* parentElementShadow = shadowWhereNodeCanBeDistributedForV0(*this)) {
if (shouldInvalidateDistributionWhenAttributeChanged(parentElementShadow, name, newValue))
parentElementShadow->setNeedsDistributionRecalc();
}
@@ -1293,6 +1293,8 @@ void Element::classAttributeChanged(const AtomicString& newClassString)
bool Element::shouldInvalidateDistributionWhenAttributeChanged(ElementShadow* elementShadow, const QualifiedName& name, const AtomicString& newValue)
{
DCHECK(elementShadow);
+ if (elementShadow->isV1())
+ return false;
const SelectRuleFeatureSet& featureSet = elementShadow->ensureSelectFeatureSet();
if (name == HTMLNames::idAttr) {
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/shadow/ElementShadow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698