Chromium Code Reviews Chromium Code Reviews
Issue
2322233004:
Landing Recent QUIC changes until Sun Sep 4 03:41:00 (Closed)
DescriptionLanding Recent QUIC changes until Sun Sep 4 03:41:00
Update flags and remove obsolete flags.
https://codereview.chromium.org/2322413002/
Add missing files from change 132003062.
Make QuicSpdyStream::FinishedReadingHeaders public. No behavior change.
Merge internal change: 132110522
https://codereview.chromium.org/2320153004/
Log error code for write errors in QuicConnection.
Merge internal change: 132094355
https://codereview.chromium.org/2320083005/
Fix two TSAN bugs exposed when running with -c opt:
1) Pause the server thread before accessing the SentPacketManager
2) Make the QuicInMemoryCache threadsafe wrt. adding/reading responses.
n/a (test only)
Merge internal change: 132080861
https://codereview.chromium.org/2327743004/
Refactor QuicCryptoServerStream.
Rather than tying the crypto server stream to SPDY, provide an interface
for implementing the load-balancing it's trying to perform so that other
(e.g. P2P) clients can utilize it without adopting SPDY in any way.
Non-functional refactor to remove dependance on QuicSpdySession from QuicCryptoServerStream.
Merge internal change: 132003062
https://codereview.chromium.org/2326073002/
Move StatelessRejector to a heap-allocated model
Note that this CL does not actually change any functionality, and several pieces necessary for supporting a fully async ValidateClientHello are missing. Those will come in a follow-up CL - this change aims simply to change the shape of the code so that later changes will be easier to understand.
Merge internal change: 131961330
https://codereview.chromium.org/2319933003/
Deprecate FLAGS_quic_never_write_unencrypted_data now that the unit tests all pass.
Merge internal change: 131901007
https://codereview.chromium.org/2325803002/
Disable QUIC versions 33 and earlier, protected by FLAGS_quic_disable_pre_34.
Merge internal change: 131866795
https://codereview.chromium.org/2323933003/
Move encrypted_buffer into QuicPacketCreator::CreateAndSerializeStreamFrame. No functional change. Not flag protected.
Merge internal change: 131823093
https://codereview.chromium.org/2326723004/
This CL adds GFE token binding support for QUIC, similar to what was added for HTTPS and SPDY.
Adds GFE token binding support for QUIC.
Merge internal change: 131797154
https://codereview.chromium.org/2328433006/
Implement an event-based simulator for QuicConnection
The simulator is meant to be used in a situations where the full logic of connection control (congestion control, loss detection, retransmission policy, ack policy) is required to properly test a scenario and an isolated unit test would risk of making unrealistic assumptions or would require too much machinery to drive.
Merge internal change: 131774129
https://codereview.chromium.org/2323963002/
Downgrade QUIC flow control violation ERROR log to DLOG(INFO).
This can be triggered by client input, shouldn't be an ERROR.
Merge internal change: 131710862
https://codereview.chromium.org/2319103002/
Allow IP migration.
Merge internal change: 131633643
https://codereview.chromium.org/2316193002/
Clean up connection when a public reset packet is received.
Merge internal change: 131623443
https://codereview.chromium.org/2319013003/
Minor refactoring in QuicDispatcher. No functional change, not flag-protected.
Merge internal change: 131614693
https://codereview.chromium.org/2318773002/
Deprecate FLAGS_quic_loss_recovery_use_largest_acked.
Merge internal change: 131603887
https://codereview.chromium.org/2310273002/
Fix all Performance and Bug-Prone patterns in quic/core. No functional change. Not flag protected.
This will probably have absolutely no impact on performance, but makes the
ClangTidy layers in codesearch a lot less noisy.
Merge internal change: 131588752
https://codereview.chromium.org/2314863003/
R=rch@chromium.org
BUG=
Committed: https://crrev.com/6c7b7ed8dab9b69224a35140ade8e32256c7d1a8
Cr-Commit-Position: refs/heads/master@{#418335}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix comments from rch@. #Patch Set 3 : Add the congestion control simulation to the build and fix compilation errors. #Patch Set 4 : Disable QuicEndpointTests because they fail, but otherwise the congestion control simulation is unu… #Patch Set 5 : Fix include orders and add a copyright. #Patch Set 6 : git cl format net #Patch Set 7 : Fix include orders and net.gypi to include a missing file. #
Total comments: 1
Patch Set 8 : Fix include order in simulator_test.cc. #Patch Set 9 : Remove crypto_test_utils_openssl.h. #Patch Set 10 : Use the default copy constructor for Packet. #Patch Set 11 : Use the default copy constructor for Packet. #Patch Set 12 : Use the default copy constructor for Packet. #Patch Set 13 : Change DLOG(INFO) to DVLOG(1). #Patch Set 14 : Remove an assignment from within a while loop, which is unsupported on Windows. #Patch Set 15 : Add NET_EXPORT_PRIVATE to QuicDefaultPacketWriter. #Patch Set 16 : Fix implicit double to float conversions in simulator_test.cc #Patch Set 17 : Another fix for simulator_test.cc. #Patch Set 18 : Remove simulation files from the build. #Depends on Patchset: Messages
Total messages: 61 (54 generated)
|
