Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: net/quic/core/quic_client_promised_info_test.cc

Issue 2322233004: Landing Recent QUIC changes until Sun Sep 4 03:41:00 (Closed)
Patch Set: Remove simulation files from the build. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_client_promised_info.cc ('k') | net/quic/core/quic_connection.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_client_promised_info_test.cc
diff --git a/net/quic/core/quic_client_promised_info_test.cc b/net/quic/core/quic_client_promised_info_test.cc
index a6e92ffecdffb021aa8aaad3fc6a0a82e8357b2c..9e38372128eb1c8a27393dd2cc39a74e4053df8f 100644
--- a/net/quic/core/quic_client_promised_info_test.cc
+++ b/net/quic/core/quic_client_promised_info_test.cc
@@ -271,7 +271,7 @@ TEST_F(QuicClientPromisedInfoTest, PushPromiseVaryWaits) {
// Now initiate rendezvous.
PushPromiseDelegate delegate(/*match=*/true);
- promised->HandleClientRequest(std::move(client_request_), &delegate);
+ promised->HandleClientRequest(client_request_, &delegate);
// Promise is still there, waiting for response.
EXPECT_NE(session_.GetPromisedById(promise_id_), nullptr);
@@ -303,7 +303,7 @@ TEST_F(QuicClientPromisedInfoTest, PushPromiseVaryNoWait) {
// Now initiate rendezvous.
PushPromiseDelegate delegate(/*match=*/true);
- promised->HandleClientRequest(std::move(client_request_), &delegate);
+ promised->HandleClientRequest(client_request_, &delegate);
// Promise is gone
EXPECT_EQ(session_.GetPromisedById(promise_id_), nullptr);
@@ -321,7 +321,7 @@ TEST_F(QuicClientPromisedInfoTest, PushPromiseWaitCancels) {
// Now initiate rendezvous.
PushPromiseDelegate delegate(/*match=*/true);
- promised->HandleClientRequest(std::move(client_request_), &delegate);
+ promised->HandleClientRequest(client_request_, &delegate);
// Promise is still there, waiting for response.
EXPECT_NE(session_.GetPromisedById(promise_id_), nullptr);
@@ -360,9 +360,8 @@ TEST_F(QuicClientPromisedInfoTest, PushPromiseDataClosed) {
// Now initiate rendezvous.
PushPromiseDelegate delegate(/*match=*/true);
- EXPECT_EQ(
- promised->HandleClientRequest(std::move(client_request_), &delegate),
- QUIC_FAILURE);
+ EXPECT_EQ(promised->HandleClientRequest(client_request_, &delegate),
+ QUIC_FAILURE);
// Got an indication of the stream failure, client should retry
// request.
« no previous file with comments | « net/quic/core/quic_client_promised_info.cc ('k') | net/quic/core/quic_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698