Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issue 2097913002: Update QuicConnectionLogger to always log missing_packets, even for v34. (Closed)

Created:
4 years, 6 months ago by ianswett
Modified:
4 years, 3 months ago
Reviewers:
Ian Swett, rch, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update QuicConnectionLogger to always log missing_packets, even for v34. R=rch@chomium.org BUG= Committed: https://crrev.com/92de36dca8a3a468dd937dcab663a47edd45cdd4 Cr-Commit-Position: refs/heads/master@{#402277}

Patch Set 1 #

Patch Set 2 : git cl format net #

Patch Set 3 : Add a test for domain names containing '_', in order to be more accepting of non-standard SNI. #

Messages

Total messages: 13 (6 generated)
ianswett
4 years, 6 months ago (2016-06-24 18:15:17 UTC) #1
Ryan Hamilton
lgtm
4 years, 5 months ago (2016-06-27 19:03:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097913002/1
4 years, 5 months ago (2016-06-27 19:04:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/207805)
4 years, 5 months ago (2016-06-27 19:15:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2097913002/20001
4 years, 5 months ago (2016-06-27 19:28:42 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 21:05:41 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 21:07:24 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92de36dca8a3a468dd937dcab663a47edd45cdd4
Cr-Commit-Position: refs/heads/master@{#402277}

Powered by Google App Engine
This is Rietveld 408576698