Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: net/quic/core/quic_packet_creator.cc

Issue 2322233004: Landing Recent QUIC changes until Sun Sep 4 03:41:00 (Closed)
Patch Set: Remove simulation files from the build. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_packet_creator.h ('k') | net/quic/core/quic_packet_creator_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_packet_creator.cc
diff --git a/net/quic/core/quic_packet_creator.cc b/net/quic/core/quic_packet_creator.cc
index d6b82a1d23f8dc3e92e60c48e08f944456d6837e..847ff6ebd63872277dc7b69f8aab9286c1c67acf 100644
--- a/net/quic/core/quic_packet_creator.cc
+++ b/net/quic/core/quic_packet_creator.cc
@@ -393,14 +393,13 @@ void QuicPacketCreator::CreateAndSerializeStreamFrame(
QuicStreamOffset stream_offset,
bool fin,
QuicAckListenerInterface* listener,
- char* encrypted_buffer,
- size_t encrypted_buffer_len,
size_t* num_bytes_consumed) {
DCHECK(queued_frames_.empty());
// Write out the packet header
QuicPacketHeader header;
FillPacketHeader(&header);
- QuicDataWriter writer(kMaxPacketSize, encrypted_buffer);
+ ALIGNAS(64) char encrypted_buffer[kMaxPacketSize];
+ QuicDataWriter writer(arraysize(encrypted_buffer), encrypted_buffer);
if (!framer_->AppendPacketHeader(header, &writer)) {
QUIC_BUG << "AppendPacketHeader failed";
return;
@@ -441,7 +440,7 @@ void QuicPacketCreator::CreateAndSerializeStreamFrame(
size_t encrypted_length = framer_->EncryptInPlace(
packet_.encryption_level, packet_.path_id, packet_.packet_number,
GetStartOfEncryptedData(framer_->version(), header), writer.length(),
- encrypted_buffer_len, encrypted_buffer);
+ arraysize(encrypted_buffer), encrypted_buffer);
if (encrypted_length == 0) {
QUIC_BUG << "Failed to encrypt packet number " << header.packet_number;
return;
@@ -612,7 +611,7 @@ bool QuicPacketCreator::ShouldRetransmit(const QuicFrame& frame) {
bool QuicPacketCreator::AddFrame(const QuicFrame& frame,
bool save_retransmittable_frames) {
DVLOG(1) << "Adding frame: " << frame;
- if (FLAGS_quic_never_write_unencrypted_data && frame.type == STREAM_FRAME &&
+ if (frame.type == STREAM_FRAME &&
frame.stream_frame->stream_id != kCryptoStreamId &&
packet_.encryption_level == ENCRYPTION_NONE) {
const string error_details = "Cannot send stream data without encryption.";
« no previous file with comments | « net/quic/core/quic_packet_creator.h ('k') | net/quic/core/quic_packet_creator_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698