Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2322223002: Make ElementShadow::oldestShadowRoot() return a reference (Closed)

Created:
4 years, 3 months ago by hayato
Modified:
4 years, 3 months ago
Reviewers:
tkent, kochi
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make ElementShadow::oldestShadowRoot() return a reference ElementShadow::m_shadowRoot is always non-nullptr here. BUG=624724 Committed: https://crrev.com/9ceaa8b24a20a5244808b8808ab37a49b24c7a40 Cr-Commit-Position: refs/heads/master@{#417559}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/SelectorQuery.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
hayato
PTAL
4 years, 3 months ago (2016-09-09 09:52:36 UTC) #4
kochi
lgtm
4 years, 3 months ago (2016-09-09 10:06:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2322223002/1
4 years, 3 months ago (2016-09-09 10:22:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 11:46:23 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 11:47:40 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9ceaa8b24a20a5244808b8808ab37a49b24c7a40
Cr-Commit-Position: refs/heads/master@{#417559}

Powered by Google App Engine
This is Rietveld 408576698