third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp - Issue 2322223002: Make ElementShadow::oldestShadowRoot() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

Issue 2322223002: Make ElementShadow::oldestShadowRoot() return a reference (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

diff --git a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

index d952b48ea3b8f0ef5dcafc15db9914bcf4d32c64..4d70d472468ef435617e7384705f61526361dc90 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

+++ b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

@@ -332,7 +332,7 @@ const SelectRuleFeatureSet& ElementShadow::ensureSelectFeatureSet()

return m_selectFeatures;

m_selectFeatures.clear();

- for (ShadowRoot* root = oldestShadowRoot(); root; root = root->youngerShadowRoot())

+ for (ShadowRoot* root = &oldestShadowRoot(); root; root = root->youngerShadowRoot())

collectSelectFeatureSetFrom(*root);

m_needsSelectFeatureSet = false;

return m_selectFeatures;