third_party/WebKit/Source/core/dom/Node.cpp - Issue 2322223002: Make ElementShadow::oldestShadowRoot() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2322223002: Make ElementShadow::oldestShadowRoot() return a reference (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Node.cpp

diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp

index 7783068ace9779adc67635bfee7dc8179401ef83..13c37a604b4bc2faaf7c613950744b12e6bd5af1 100644

--- a/third_party/WebKit/Source/core/dom/Node.cpp

+++ b/third_party/WebKit/Source/core/dom/Node.cpp

@@ -580,7 +580,7 @@ inline static ShadowRoot* oldestShadowRootFor(const Node* node)

if (!node->isElementNode())

return nullptr;

if (ElementShadow* shadow = toElement(node)->shadow())

- return shadow->oldestShadowRoot();

+ return &shadow->oldestShadowRoot();

return nullptr;

}

#endif