third_party/WebKit/Source/core/dom/SelectorQuery.cpp - Issue 2322223002: Make ElementShadow::oldestShadowRoot() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/SelectorQuery.cpp

Issue 2322223002: Make ElementShadow::oldestShadowRoot() return a reference (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/SelectorQuery.cpp

diff --git a/third_party/WebKit/Source/core/dom/SelectorQuery.cpp b/third_party/WebKit/Source/core/dom/SelectorQuery.cpp

index d89ba13bb96443b09d16a31aa64c3cf231fb0466..da126196127b99d4d2de63067f2a9742e1c329c3 100644

--- a/third_party/WebKit/Source/core/dom/SelectorQuery.cpp

+++ b/third_party/WebKit/Source/core/dom/SelectorQuery.cpp

@@ -393,7 +393,7 @@ static ShadowRoot* authorShadowRootOf(const ContainerNode& node)

ElementShadow* shadow = toElement(node).shadow();

DCHECK(shadow);

- for (ShadowRoot* shadowRoot = shadow->oldestShadowRoot(); shadowRoot; shadowRoot = shadowRoot->youngerShadowRoot()) {

+ for (ShadowRoot* shadowRoot = &shadow->oldestShadowRoot(); shadowRoot; shadowRoot = shadowRoot->youngerShadowRoot()) {

if (shadowRoot->type() == ShadowRootType::V0 || shadowRoot->type() == ShadowRootType::Open)

return shadowRoot;

}