Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2322223002: Make ElementShadow::oldestShadowRoot() return a reference (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 562 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 return LayoutRect(layoutObject()->absoluteBoundingBoxRect()); 573 return LayoutRect(layoutObject()->absoluteBoundingBoxRect());
574 return LayoutRect(); 574 return LayoutRect();
575 } 575 }
576 576
577 #ifndef NDEBUG 577 #ifndef NDEBUG
578 inline static ShadowRoot* oldestShadowRootFor(const Node* node) 578 inline static ShadowRoot* oldestShadowRootFor(const Node* node)
579 { 579 {
580 if (!node->isElementNode()) 580 if (!node->isElementNode())
581 return nullptr; 581 return nullptr;
582 if (ElementShadow* shadow = toElement(node)->shadow()) 582 if (ElementShadow* shadow = toElement(node)->shadow())
583 return shadow->oldestShadowRoot(); 583 return &shadow->oldestShadowRoot();
584 return nullptr; 584 return nullptr;
585 } 585 }
586 #endif 586 #endif
587 587
588 Node& Node::shadowIncludingRoot() const 588 Node& Node::shadowIncludingRoot() const
589 { 589 {
590 if (isConnected()) 590 if (isConnected())
591 return document(); 591 return document();
592 Node* root = const_cast<Node*>(this); 592 Node* root = const_cast<Node*>(this);
593 while (Node* host = root->shadowHost()) 593 while (Node* host = root->shadowHost())
(...skipping 1817 matching lines...) Expand 10 before | Expand all | Expand 10 after
2411 if (node) { 2411 if (node) {
2412 std::stringstream stream; 2412 std::stringstream stream;
2413 node->printNodePathTo(stream); 2413 node->printNodePathTo(stream);
2414 LOG(INFO) << stream.str(); 2414 LOG(INFO) << stream.str();
2415 } else { 2415 } else {
2416 LOG(INFO) << "Cannot showNodePath for <null>"; 2416 LOG(INFO) << "Cannot showNodePath for <null>";
2417 } 2417 }
2418 } 2418 }
2419 2419
2420 #endif 2420 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/dom/SelectorQuery.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698