third_party/WebKit/Source/core/dom/Element.cpp - Issue 2322223002: Make ElementShadow::oldestShadowRoot() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2322223002: Make ElementShadow::oldestShadowRoot() return a reference (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index 1e9ac996a103133d46428a7536e41ccbf27841a7..ad042b3339e86f651b2df0962a20a87c5a47b063 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -2119,10 +2119,9 @@ ShadowRoot* Element::authorShadowRoot() const

ShadowRoot* Element::userAgentShadowRoot() const

{

if (ElementShadow* elementShadow = shadow()) {

- if (ShadowRoot* root = elementShadow->oldestShadowRoot()) {

- DCHECK(root->type() == ShadowRootType::UserAgent);

- return root;

- }

+ ShadowRoot& root = elementShadow->oldestShadowRoot();

+ DCHECK(root.type() == ShadowRootType::UserAgent);

+ return &root;

}

return nullptr;