Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2322223002: Make ElementShadow::oldestShadowRoot() return a reference (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2101 matching lines...) Expand 10 before | Expand all | Expand 10 after
2112 { 2112 {
2113 ShadowRoot* root = shadowRoot(); 2113 ShadowRoot* root = shadowRoot();
2114 if (!root) 2114 if (!root)
2115 return nullptr; 2115 return nullptr;
2116 return root->type() != ShadowRootType::UserAgent ? root : nullptr; 2116 return root->type() != ShadowRootType::UserAgent ? root : nullptr;
2117 } 2117 }
2118 2118
2119 ShadowRoot* Element::userAgentShadowRoot() const 2119 ShadowRoot* Element::userAgentShadowRoot() const
2120 { 2120 {
2121 if (ElementShadow* elementShadow = shadow()) { 2121 if (ElementShadow* elementShadow = shadow()) {
2122 if (ShadowRoot* root = elementShadow->oldestShadowRoot()) { 2122 ShadowRoot& root = elementShadow->oldestShadowRoot();
2123 DCHECK(root->type() == ShadowRootType::UserAgent); 2123 DCHECK(root.type() == ShadowRootType::UserAgent);
2124 return root; 2124 return &root;
2125 }
2126 } 2125 }
2127 2126
2128 return nullptr; 2127 return nullptr;
2129 } 2128 }
2130 2129
2131 ShadowRoot& Element::ensureUserAgentShadowRoot() 2130 ShadowRoot& Element::ensureUserAgentShadowRoot()
2132 { 2131 {
2133 if (ShadowRoot* shadowRoot = userAgentShadowRoot()) 2132 if (ShadowRoot* shadowRoot = userAgentShadowRoot())
2134 return *shadowRoot; 2133 return *shadowRoot;
2135 ShadowRoot& shadowRoot = ensureShadow().addShadowRoot(*this, ShadowRootType: :UserAgent); 2134 ShadowRoot& shadowRoot = ensureShadow().addShadowRoot(*this, ShadowRootType: :UserAgent);
(...skipping 1682 matching lines...) Expand 10 before | Expand all | Expand 10 after
3818 3817
3819 DEFINE_TRACE_WRAPPERS(Element) 3818 DEFINE_TRACE_WRAPPERS(Element)
3820 { 3819 {
3821 if (hasRareData()) { 3820 if (hasRareData()) {
3822 visitor->traceWrappers(elementRareData()); 3821 visitor->traceWrappers(elementRareData());
3823 } 3822 }
3824 ContainerNode::traceWrappers(visitor); 3823 ContainerNode::traceWrappers(visitor);
3825 } 3824 }
3826 3825
3827 } // namespace blink 3826 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp ('k') | third_party/WebKit/Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698