third_party/WebKit/Source/core/dom/shadow/ElementShadow.h - Issue 2322223002: Make ElementShadow::oldestShadowRoot() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

Issue 2322223002: Make ElementShadow::oldestShadowRoot() return a reference (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

diff --git a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

index 95b935dde01cac2aa767d47e872bfa575a98d600..57050d2b879081988233dce903be7161fbec677c 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

+++ b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.h

@@ -45,7 +45,7 @@ public:

Element& host() const;

ShadowRoot& youngestShadowRoot() const;

- ShadowRoot* oldestShadowRoot() const { return m_shadowRoot; }

+ ShadowRoot& oldestShadowRoot() const { DCHECK(m_shadowRoot); return *m_shadowRoot; }

ElementShadow* containingShadow() const;

ShadowRoot& addShadowRoot(Element& shadowHost, ShadowRootType);