Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2318523006: Merge GrGLSLProgramDesc into GrProgramDesc (Closed)

Created:
4 years, 3 months ago by egdaniel
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Merge GrGLSLProgramDesc into GrProgramDesc BUG=skia: Committed: https://skia.googlesource.com/skia/+/5d8f69f2d492a15189e4b976ccca3fa092876419

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add GrProgramDesc file #

Patch Set 4 : build fix, VS is too nice #

Total comments: 4

Patch Set 5 : update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -300 lines) Patch
M gyp/gpu.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrProgramDesc.h View 1 2 3 4 4 chunks +39 lines, -14 lines 0 comments Download
A + src/gpu/GrProgramDesc.cpp View 1 2 6 chunks +12 lines, -15 lines 0 comments Download
M src/gpu/gl/GrGLGpuProgramCache.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
D src/gpu/glsl/GrGLSLProgramDesc.h View 1 chunk +0 lines, -63 lines 0 comments Download
D src/gpu/glsl/GrGLSLProgramDesc.cpp View 1 chunk +0 lines, -187 lines 0 comments Download
M src/gpu/vk/GrVkPipelineState.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineStateCache.cpp View 1 1 chunk +2 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (16 generated)
egdaniel
This just does the merging of the two ProgramDesc files together. Also moves the finalize ...
4 years, 3 months ago (2016-09-06 20:38:20 UTC) #2
bsalomon
lgtm, comment comments https://codereview.chromium.org/2318523006/diff/60001/src/gpu/GrProgramDesc.h File src/gpu/GrProgramDesc.h (right): https://codereview.chromium.org/2318523006/diff/60001/src/gpu/GrProgramDesc.h#newcode27 src/gpu/GrProgramDesc.h:27: * Builds a program descriptor Note ...
4 years, 3 months ago (2016-09-07 13:41:15 UTC) #15
egdaniel
https://codereview.chromium.org/2318523006/diff/60001/src/gpu/GrProgramDesc.h File src/gpu/GrProgramDesc.h (right): https://codereview.chromium.org/2318523006/diff/60001/src/gpu/GrProgramDesc.h#newcode27 src/gpu/GrProgramDesc.h:27: * Builds a program descriptor On 2016/09/07 13:41:15, bsalomon ...
4 years, 3 months ago (2016-09-07 13:53:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318523006/80001
4 years, 3 months ago (2016-09-07 13:53:52 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 14:24:14 UTC) #21
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/5d8f69f2d492a15189e4b976ccca3fa092876419

Powered by Google App Engine
This is Rietveld 408576698