Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2318143002: Merge building of program desc in Vulkan into one step (Closed)

Created:
4 years, 3 months ago by egdaniel
Modified:
4 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Merge building of program desc in Vulkan into one step BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318143002 Committed: https://skia.googlesource.com/skia/+/720dc71cfe79d708b28829b99d1ecf4b1e192621

Patch Set 1 #

Patch Set 2 : filled with debug #

Patch Set 3 : cleanup #

Patch Set 4 : more cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -98 lines) Patch
M src/gpu/vk/GrVkPipelineState.h View 1 2 3 1 chunk +12 lines, -74 lines 0 comments Download
M src/gpu/vk/GrVkPipelineState.cpp View 1 2 2 chunks +10 lines, -11 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateBuilder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/vk/GrVkPipelineStateCache.cpp View 1 2 2 chunks +4 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
egdaniel
4 years, 3 months ago (2016-09-07 18:03:25 UTC) #3
bsalomon
lgtm
4 years, 3 months ago (2016-09-07 18:08:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318143002/60001
4 years, 3 months ago (2016-09-07 18:15:24 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 18:57:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/720dc71cfe79d708b28829b99d1ecf4b1e192621

Powered by Google App Engine
This is Rietveld 408576698