Chromium Code Reviews
DescriptionRevert "Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton."
See crbug.com/642364 and additional comments on
https://codereview.chromium.org/2304733002/
Original description:
> Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton.
>
> CrashDumpManager watches for generated microdumps when child processes
> die, and CrashMicroDumpManager is responsible for aborting the WebView
> browser process. Both share similarities that can be combined, and doing
> so allows us to eventually support generating a minidump and then dying
> in WebView.
>
> BUG=633979
>
> Review-Url: https://codereview.chromium.org/2200693002
> Cr-Commit-Position: refs/heads/master@{#413431}
BUG=642364
TBR=tobiasjs,torne,sanfin,alokp,halliwell,mkwst,rsesek,bauerb
Committed: https://crrev.com/f4d9dc0e8f7c4ff10c8de53bb03e7518a0d6d87f
Cr-Commit-Position: refs/heads/master@{#416178}
Patch Set 1 #Messages
Total messages: 9 (5 generated)
|