Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2303153002: Revert "Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton." (Closed)

Created:
4 years, 3 months ago by boliu
Modified:
4 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, sadrul, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, lcwu+watch_chromium.org, jam, darin-cc_chromium.org, halliwell+watch_chromium.org, kalyank, alokp+watch_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org, einbinder+watch-test-runner_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton." See crbug.com/642364 and additional comments on https://codereview.chromium.org/2304733002/ Original description: > Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton. > > CrashDumpManager watches for generated microdumps when child processes > die, and CrashMicroDumpManager is responsible for aborting the WebView > browser process. Both share similarities that can be combined, and doing > so allows us to eventually support generating a minidump and then dying > in WebView. > > BUG=633979 > > Review-Url: https://codereview.chromium.org/2200693002 > Cr-Commit-Position: refs/heads/master@{#413431} BUG=642364 TBR=tobiasjs,torne,sanfin,alokp,halliwell,mkwst,rsesek,bauerb Committed: https://crrev.com/f4d9dc0e8f7c4ff10c8de53bb03e7518a0d6d87f Cr-Commit-Position: refs/heads/master@{#416178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+447 lines, -496 lines) Patch
M android_webview/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/aw_browser_main_parts.h View 2 chunks +0 lines, -2 lines 0 comments Download
M android_webview/browser/aw_browser_main_parts.cc View 4 chunks +2 lines, -7 lines 0 comments Download
D android_webview/browser/aw_browser_terminator.h View 1 chunk +0 lines, -52 lines 0 comments Download
D android_webview/browser/aw_browser_terminator.cc View 1 chunk +0 lines, -78 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main_android.cc View 3 chunks +5 lines, -13 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M chromecast/browser/cast_browser_process.h View 3 chunks +11 lines, -0 lines 0 comments Download
M chromecast/browser/cast_browser_process.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M components/crash/content/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M components/crash/content/browser/crash_dump_manager_android.h View 3 chunks +53 lines, -23 lines 0 comments Download
M components/crash/content/browser/crash_dump_manager_android.cc View 8 chunks +108 lines, -24 lines 0 comments Download
D components/crash/content/browser/crash_dump_observer_android.h View 1 chunk +0 lines, -96 lines 0 comments Download
D components/crash/content/browser/crash_dump_observer_android.cc View 1 chunk +0 lines, -152 lines 0 comments Download
A components/crash/content/browser/crash_micro_dump_manager_android.h View 1 chunk +69 lines, -0 lines 0 comments Download
A components/crash/content/browser/crash_micro_dump_manager_android.cc View 1 chunk +129 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_main_parts.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.h View 3 chunks +7 lines, -8 lines 0 comments Download
M content/shell/browser/shell_browser_main_parts.cc View 4 chunks +1 line, -10 lines 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
boliu
4 years, 3 months ago (2016-09-02 01:38:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2303153002/1
4 years, 3 months ago (2016-09-02 01:41:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-02 03:25:13 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 03:27:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4d9dc0e8f7c4ff10c8de53bb03e7518a0d6d87f
Cr-Commit-Position: refs/heads/master@{#416178}

Powered by Google App Engine
This is Rietveld 408576698