Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5777)

Unified Diff: chromecast/browser/cast_browser_main_parts.cc

Issue 2303153002: Revert "Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton." (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/cast_browser_main_parts.h ('k') | chromecast/browser/cast_browser_process.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/cast_browser_main_parts.cc
diff --git a/chromecast/browser/cast_browser_main_parts.cc b/chromecast/browser/cast_browser_main_parts.cc
index fb372faa37a726f83bce3b07206b38df14f3616c..ef433430d5a9af8d8e8cf07e9cdebd26db629289 100644
--- a/chromecast/browser/cast_browser_main_parts.cc
+++ b/chromecast/browser/cast_browser_main_parts.cc
@@ -39,7 +39,6 @@
#include "chromecast/browser/pref_service_helper.h"
#include "chromecast/browser/url_request_context_factory.h"
#include "chromecast/chromecast_features.h"
-#include "chromecast/common/global_descriptors.h"
#include "chromecast/common/platform_client_auth.h"
#include "chromecast/media/base/key_systems_common.h"
#include "chromecast/media/base/media_resource_tracker.h"
@@ -297,9 +296,6 @@ CastBrowserMainParts::~CastBrowserMainParts() {
media_thread_->task_runner()->DeleteSoon(
FROM_HERE, media_pipeline_backend_manager_.release());
}
-#else
- breakpad::CrashDumpObserver::GetInstance()->UnregisterClient(
- crash_dump_manager_.get());
#endif // !defined(OS_ANDROID)
}
@@ -393,10 +389,8 @@ int CastBrowserMainParts::PreCreateThreads() {
if (!chromecast::CrashHandler::GetCrashDumpLocation(&crash_dumps_dir)) {
LOG(ERROR) << "Could not find crash dump location.";
}
- crash_dump_manager_ = base::MakeUnique<breakpad::CrashDumpManager>(
- crash_dumps_dir, kAndroidMinidumpDescriptor);
- breakpad::CrashDumpObserver::GetInstance()->RegisterClient(
- crash_dump_manager_.get());
+ cast_browser_process_->SetCrashDumpManager(
+ base::MakeUnique<breakpad::CrashDumpManager>(crash_dumps_dir));
#else
base::FilePath home_dir;
CHECK(PathService::Get(DIR_CAST_HOME, &home_dir));
« no previous file with comments | « chromecast/browser/cast_browser_main_parts.h ('k') | chromecast/browser/cast_browser_process.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698