Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3244)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2303153002: Revert "Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton." (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chrome_browser_main_android.cc ('k') | chromecast/browser/cast_browser_main_parts.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 1e98c971f84eccd44dea1102742d98f9d6fe3713..c5dfbf0d6ba2ca4b78a2e525feafb33a15af7661 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -2719,8 +2719,18 @@ void ChromeContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
fd = ui::GetLocalePackFd(&(*regions)[kAndroidLocalePakDescriptor]);
mappings->Share(kAndroidLocalePakDescriptor, fd);
- breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(
- child_process_id, mappings);
+ if (breakpad::IsCrashReporterEnabled()) {
+ base::File file =
+ breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
+ child_process_id);
+ if (file.IsValid()) {
+ mappings->Transfer(kAndroidMinidumpDescriptor,
+ base::ScopedFD(file.TakePlatformFile()));
+ } else {
+ LOG(ERROR) << "Failed to create file for minidump, crash reporting will "
+ "be disabled for this process.";
+ }
+ }
base::FilePath app_data_path;
PathService::Get(base::DIR_ANDROID_APP_DATA, &app_data_path);
« no previous file with comments | « chrome/browser/chrome_browser_main_android.cc ('k') | chromecast/browser/cast_browser_main_parts.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698