Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: chromecast/browser/cast_content_browser_client.cc

Issue 2303153002: Revert "Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton." (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/cast_browser_process.cc ('k') | components/crash/content/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/cast_content_browser_client.cc
diff --git a/chromecast/browser/cast_content_browser_client.cc b/chromecast/browser/cast_content_browser_client.cc
index f8232a324de3cea748a2ba59f92a821e48d4a3eb..dfc485d63579814c4da4aca364f994e49290eb44 100644
--- a/chromecast/browser/cast_content_browser_client.cc
+++ b/chromecast/browser/cast_content_browser_client.cc
@@ -456,8 +456,18 @@ void CastContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
kAndroidPakDescriptor, base::GlobalDescriptors::GetInstance()->GetRegion(
kAndroidPakDescriptor)));
- breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(
- child_process_id, mappings);
+ if (breakpad::IsCrashReporterEnabled()) {
+ base::File minidump_file(
+ breakpad::CrashDumpManager::GetInstance()->CreateMinidumpFile(
+ child_process_id));
+ if (!minidump_file.IsValid()) {
+ LOG(ERROR) << "Failed to create file for minidump, crash reporting will "
+ << "be disabled for this process.";
+ } else {
+ mappings->Transfer(kAndroidMinidumpDescriptor,
+ base::ScopedFD(minidump_file.TakePlatformFile()));
+ }
+ }
}
#else
« no previous file with comments | « chromecast/browser/cast_browser_process.cc ('k') | components/crash/content/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698