Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2680)

Unified Diff: android_webview/browser/aw_content_browser_client.cc

Issue 2303153002: Revert "Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton." (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/aw_browser_terminator.cc ('k') | chrome/browser/chrome_browser_main_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_content_browser_client.cc
diff --git a/android_webview/browser/aw_content_browser_client.cc b/android_webview/browser/aw_content_browser_client.cc
index dbb8c83f694bc111308bfad9dce1430e14d6b4bb..122c007d3a1409fd5bb57ef3a4e5821f36e0a79b 100644
--- a/android_webview/browser/aw_content_browser_client.cc
+++ b/android_webview/browser/aw_content_browser_client.cc
@@ -31,7 +31,7 @@
#include "base/memory/ptr_util.h"
#include "base/path_service.h"
#include "components/cdm/browser/cdm_message_filter_android.h"
-#include "components/crash/content/browser/crash_dump_observer_android.h"
+#include "components/crash/content/browser/crash_micro_dump_manager_android.h"
#include "components/navigation_interception/intercept_navigation_delegate.h"
#include "content/public/browser/browser_message_filter.h"
#include "content/public/browser/browser_thread.h"
@@ -486,8 +486,13 @@ void AwContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
fd = ui::GetLocalePackFd(&(*regions)[kAndroidWebViewLocalePakDescriptor]);
mappings->Share(kAndroidWebViewLocalePakDescriptor, fd);
- breakpad::CrashDumpObserver::GetInstance()->BrowserChildProcessStarted(
- child_process_id, mappings);
+ base::ScopedFD crash_signal_file =
+ breakpad::CrashMicroDumpManager::GetInstance()->CreateCrashInfoChannel(
+ child_process_id);
+ if (crash_signal_file.is_valid()) {
+ mappings->Transfer(kAndroidWebViewCrashSignalDescriptor,
+ std::move(crash_signal_file));
+ }
}
void AwContentBrowserClient::OverrideWebkitPrefs(
« no previous file with comments | « android_webview/browser/aw_browser_terminator.cc ('k') | chrome/browser/chrome_browser_main_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698