Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1055)

Unified Diff: android_webview/browser/aw_browser_terminator.h

Issue 2303153002: Revert "Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton." (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/aw_browser_main_parts.cc ('k') | android_webview/browser/aw_browser_terminator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_browser_terminator.h
diff --git a/android_webview/browser/aw_browser_terminator.h b/android_webview/browser/aw_browser_terminator.h
deleted file mode 100644
index 286eb7218211e2e011b0e686bc683f0148ade07b..0000000000000000000000000000000000000000
--- a/android_webview/browser/aw_browser_terminator.h
+++ /dev/null
@@ -1,52 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef COMPONENTS_CRASH_CONTENT_BROWSER_CRASH_DUMP_BROWSER_TERMINATOR_H_
-#define COMPONENTS_CRASH_CONTENT_BROWSER_CRASH_DUMP_BROWSER_TERMINATOR_H_
-
-#include <map>
-
-#include "base/synchronization/lock.h"
-#include "components/crash/content/browser/crash_dump_observer_android.h"
-
-namespace base {
-class SyncSocket;
-}
-
-namespace android_webview {
-
-// This class manages behavior of the browser on renderer crashes when
-// microdumps are used for capturing the crash stack. Normally, in this case
-// the browser doesn't need to do much, because a microdump is written into
-// Android log by the renderer process itself. However, the browser may need to
-// crash itself on a renderer crash. Since on Android renderers are not child
-// processes of the browser, it can't access the exit code. Instead, the browser
-// uses a dedicated pipe in order to receive the information about the renderer
-// crash status.
-class AwBrowserTerminator : public breakpad::CrashDumpObserver::Client {
- public:
- AwBrowserTerminator();
- ~AwBrowserTerminator() override;
-
- // breakpad::CrashDumpObserver::Client implementation.
- void OnChildStart(int child_process_id,
- content::FileDescriptorInfo* mappings) override;
- void OnChildExit(int child_process_id,
- base::ProcessHandle pid,
- content::ProcessType process_type,
- base::TerminationStatus termination_status,
- base::android::ApplicationState app_state) override;
-
- private:
- // This map should only be accessed with its lock aquired as it is accessed
- // from the PROCESS_LAUNCHER, FILE, and UI threads.
- base::Lock child_process_id_to_pipe_lock_;
- std::map<int, std::unique_ptr<base::SyncSocket>> child_process_id_to_pipe_;
-
- DISALLOW_COPY_AND_ASSIGN(AwBrowserTerminator);
-};
-
-} // namespace breakpad
-
-#endif // COMPONENTS_CRASH_CONTENT_BROWSER_CRASH_DUMP_BROWSER_TERMINATOR_H_
« no previous file with comments | « android_webview/browser/aw_browser_main_parts.cc ('k') | android_webview/browser/aw_browser_terminator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698