Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1210)

Unified Diff: android_webview/browser/aw_browser_main_parts.cc

Issue 2303153002: Revert "Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton." (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/aw_browser_main_parts.h ('k') | android_webview/browser/aw_browser_terminator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_browser_main_parts.cc
diff --git a/android_webview/browser/aw_browser_main_parts.cc b/android_webview/browser/aw_browser_main_parts.cc
index 9cc0883f4c6c49c8ecd5f46efb85cf6d6817bef1..769fcf4f1809914af4c08429e6271ae365f3e8a7 100644
--- a/android_webview/browser/aw_browser_main_parts.cc
+++ b/android_webview/browser/aw_browser_main_parts.cc
@@ -5,7 +5,6 @@
#include "android_webview/browser/aw_browser_main_parts.h"
#include "android_webview/browser/aw_browser_context.h"
-#include "android_webview/browser/aw_browser_terminator.h"
#include "android_webview/browser/aw_content_browser_client.h"
#include "android_webview/browser/aw_dev_tools_discovery_provider.h"
#include "android_webview/browser/aw_result_codes.h"
@@ -21,7 +20,7 @@
#include "base/files/file_path.h"
#include "base/i18n/rtl.h"
#include "base/path_service.h"
-#include "components/crash/content/browser/crash_dump_observer_android.h"
+#include "components/crash/content/browser/crash_micro_dump_manager_android.h"
#include "content/public/browser/android/synchronous_compositor.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h"
@@ -83,8 +82,6 @@ AwBrowserMainParts::AwBrowserMainParts(AwContentBrowserClient* browser_client)
}
AwBrowserMainParts::~AwBrowserMainParts() {
- breakpad::CrashDumpObserver::GetInstance()->UnregisterClient(
- aw_browser_terminator_.get());
}
void AwBrowserMainParts::PreEarlyInitialization() {
@@ -122,9 +119,7 @@ int AwBrowserMainParts::PreCreateThreads() {
if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
switches::kSingleProcess)) {
// Create the renderers crash manager on the UI thread.
- aw_browser_terminator_ = base::MakeUnique<AwBrowserTerminator>();
- breakpad::CrashDumpObserver::GetInstance()->RegisterClient(
- aw_browser_terminator_.get());
+ breakpad::CrashMicroDumpManager::GetInstance();
}
return content::RESULT_CODE_NORMAL_EXIT;
« no previous file with comments | « android_webview/browser/aw_browser_main_parts.h ('k') | android_webview/browser/aw_browser_terminator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698