Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: content/shell/browser/shell_browser_main_parts.h

Issue 2303153002: Revert "Refactor CrashDump*Manager to use a shared CrashDumpObserver singleton." (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_SHELL_BROWSER_SHELL_BROWSER_MAIN_PARTS_H_ 5 #ifndef CONTENT_SHELL_BROWSER_SHELL_BROWSER_MAIN_PARTS_H_
6 #define CONTENT_SHELL_BROWSER_SHELL_BROWSER_MAIN_PARTS_H_ 6 #define CONTENT_SHELL_BROWSER_SHELL_BROWSER_MAIN_PARTS_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "build/build_config.h" 11 #include "build/build_config.h"
12 #include "content/public/browser/browser_main_parts.h" 12 #include "content/public/browser/browser_main_parts.h"
13 #include "content/public/common/main_function_params.h" 13 #include "content/public/common/main_function_params.h"
14 #include "content/shell/browser/shell_browser_context.h" 14 #include "content/shell/browser/shell_browser_context.h"
15 15
16 namespace base {
17 class Thread;
18 }
19
20 #if defined(OS_ANDROID) 16 #if defined(OS_ANDROID)
21 namespace breakpad { 17 namespace breakpad {
22 class CrashDumpManager; 18 class CrashDumpManager;
23 } 19 }
24 #endif 20 #endif
25 21
22 namespace base {
23 class Thread;
24 }
25
26 namespace devtools_http_handler { 26 namespace devtools_http_handler {
27 class DevToolsHttpHandler; 27 class DevToolsHttpHandler;
28 } 28 }
29 29
30 namespace net { 30 namespace net {
31 class NetLog; 31 class NetLog;
32 } 32 }
33 33
34 namespace content { 34 namespace content {
35 35
(...skipping 30 matching lines...) Expand all
66 virtual void InitializeMessageLoopContext(); 66 virtual void InitializeMessageLoopContext();
67 67
68 void set_browser_context(ShellBrowserContext* context) { 68 void set_browser_context(ShellBrowserContext* context) {
69 browser_context_.reset(context); 69 browser_context_.reset(context);
70 } 70 }
71 void set_off_the_record_browser_context(ShellBrowserContext* context) { 71 void set_off_the_record_browser_context(ShellBrowserContext* context) {
72 off_the_record_browser_context_.reset(context); 72 off_the_record_browser_context_.reset(context);
73 } 73 }
74 74
75 private: 75 private:
76 #if defined(OS_ANDROID)
77 std::unique_ptr<breakpad::CrashDumpManager> crash_dump_manager_;
78 #endif
76 std::unique_ptr<net::NetLog> net_log_; 79 std::unique_ptr<net::NetLog> net_log_;
77 std::unique_ptr<ShellBrowserContext> browser_context_; 80 std::unique_ptr<ShellBrowserContext> browser_context_;
78 std::unique_ptr<ShellBrowserContext> off_the_record_browser_context_; 81 std::unique_ptr<ShellBrowserContext> off_the_record_browser_context_;
79 82
80 // For running content_browsertests. 83 // For running content_browsertests.
81 const MainFunctionParams parameters_; 84 const MainFunctionParams parameters_;
82 bool run_message_loop_; 85 bool run_message_loop_;
83 86
84 std::unique_ptr<devtools_http_handler::DevToolsHttpHandler> 87 std::unique_ptr<devtools_http_handler::DevToolsHttpHandler>
85 devtools_http_handler_; 88 devtools_http_handler_;
86 89
87 #if defined(OS_ANDROID)
88 std::unique_ptr<breakpad::CrashDumpManager> crash_dump_manager_;
89 #endif
90
91 DISALLOW_COPY_AND_ASSIGN(ShellBrowserMainParts); 90 DISALLOW_COPY_AND_ASSIGN(ShellBrowserMainParts);
92 }; 91 };
93 92
94 } // namespace content 93 } // namespace content
95 94
96 #endif // CONTENT_SHELL_BROWSER_SHELL_BROWSER_MAIN_PARTS_H_ 95 #endif // CONTENT_SHELL_BROWSER_SHELL_BROWSER_MAIN_PARTS_H_
OLDNEW
« no previous file with comments | « content/shell/browser/layout_test/layout_test_browser_main_parts.h ('k') | content/shell/browser/shell_browser_main_parts.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698