Added Pose attribute to Gamepad

Added Pose attribute to Gamepad

BUG=628417
TBR=mkwst@chromium.org

Committed: https://crrev.com/cf1c8194679b51a0cd3f8c38b4b5101957bda6f6
Cr-Commit-Position: refs/heads/master@{#419564}

[bajones, 2016-09-09 23:03:50]

bajones@chromium.org changed reviewers:
+ bbudge@chromium.org, mkwst@chromium.org

[bajones, 2016-09-09 23:03:51]

bbudge@chromium.org: Please review changes in ppapi/
mkwst@chromium.org: Please review changes in modules/

This is part of a series of extensions to the Gamepad API to enable VR
controllers (among others). Functionality is behind a while spec discussions are
ongoing.

[bajones, 2016-09-09 23:59:03]

The CQ bit was checked by bajones@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 23:59:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 00:03:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 00:03:24]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[haraken, 2016-09-10 01:25:42]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-09-10 01:25:42]

https://codereview.chromium.org/2300543003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/gamepad/GamepadPose.idl (right):

https://codereview.chromium.org/2300543003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/gamepad/GamepadPose.idl:4: 

Add a link to the spec.

[Mike West, 2016-09-12 07:21:29]

Is this actually specified somewhere? I found
https://lists.w3.org/Archives/Public/public-webapps/2016AprJun/0052.html in a
quick search, but I find it a little difficult to determine whether this patch
does what that email says it should.

(Also, it's greatly helpful if you add the `--no-find-copies` flag to `git cl
upload` when you add new files; the diff here is pretty hard to parse when
framed as a copy of an existing set of files.)

https://codereview.chromium.org/2300543003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/gamepad/Gamepad.idl (right):

https://codereview.chromium.org/2300543003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/gamepad/Gamepad.idl:26: [
Nit: This needs a spec link as well.

[bajones, 2016-09-17 01:02:18]

Apologies for the delayed response to questions about the spec. I was waiting
for this to land in the w3c repo:
https://w3c.github.io/gamepad/extensions.html

Added the requested comments, and ensured the GamepadPose interface is only
available behind the GamepadExtensions flag. Please take another look!

[bajones, 2016-09-19 18:34:15]

bajones@chromium.org changed reviewers:
+ aelias@chromium.org, dcheng@chromium.org, raymes@chromium.org

[bajones, 2016-09-19 18:34:15]

Hmm... seems like a bunch of reviewers are at TPAC this week.

aelias@ or dcheng@: Could you review the public/platform/ changes?

bbudge@ or raymes@: Could you review the ppapi/ change?

[aelias_OOO_until_Jul13, 2016-09-19 19:05:23]

lgtm

[bbudge, 2016-09-19 19:18:01]

lgtm

[bajones, 2016-09-19 19:39:46]

Description was changed from

==========
Added Pose attribute to Gamepad

BUG=628417
==========

to

==========
Added Pose attribute to Gamepad

BUG=628417

TBR=mkwst@chromium.org
==========

[bajones, 2016-09-19 19:40:25]

Thanks! TBRing mkwst@ for the modules_idl_files.gni change because TPAC.

[bajones, 2016-09-19 19:40:35]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:41:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 19:45:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 19:45:51]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[bajones, 2016-09-19 20:08:42]

The CQ bit was checked by bajones@chromium.org

[bajones, 2016-09-19 20:08:43]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
bbudge@chromium.org
Link to the patchset: https://codereview.chromium.org/2300543003/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-19 20:09:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 21:38:02]

Description was changed from

==========
Added Pose attribute to Gamepad

BUG=628417

TBR=mkwst@chromium.org
==========

to

==========
Added Pose attribute to Gamepad

BUG=628417

TBR=mkwst@chromium.org
==========

[commit-bot: I haz the power, 2016-09-19 21:38:03]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-19 21:40:48]

Description was changed from

==========
Added Pose attribute to Gamepad

BUG=628417

TBR=mkwst@chromium.org
==========

to

==========
Added Pose attribute to Gamepad

BUG=628417

TBR=mkwst@chromium.org

Committed: https://crrev.com/cf1c8194679b51a0cd3f8c38b4b5101957bda6f6
Cr-Commit-Position: refs/heads/master@{#419564}
==========

[commit-bot: I haz the power, 2016-09-19 21:40:50]

Patchset 7 (id:??) landed as
https://crrev.com/cf1c8194679b51a0cd3f8c38b4b5101957bda6f6
Cr-Commit-Position: refs/heads/master@{#419564}