Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable… (Closed)

Created:
4 years, 3 months ago by lunalu1
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
tkent, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable elements. BUG=642267 Committed: https://crrev.com/8c5fd085e7108025af04004150ee65c09e93d404 Cr-Commit-Position: refs/heads/master@{#416181}

Patch Set 1 #

Patch Set 2 : Cleaner code #

Patch Set 3 : Added a layout test #

Total comments: 11

Patch Set 4 : Code review update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/html/tabindex-nonfocusable.html View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFieldSetElement.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFormControlElement.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOutputElement.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLOutputElement.cpp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
tkent
We should override tabIndex() in HTMLFieldSetElement and HTMLOutputElement. Also, this needs a layout test.
4 years, 3 months ago (2016-09-01 02:08:39 UTC) #3
lunalu1
On 2016/09/01 02:08:39, tkent wrote: > We should override tabIndex() in HTMLFieldSetElement and HTMLOutputElement. > ...
4 years, 3 months ago (2016-09-01 18:01:06 UTC) #4
lunalu1
Hi tkent, Thank you for the feedback. I overridden tabIndex() in HTMLFieldSetElement and HTMLOutputElement, and ...
4 years, 3 months ago (2016-09-01 18:05:44 UTC) #5
tkent
I think Patch Set 3 breaks fast/events/tabindex-focus-blur-all.html. https://codereview.chromium.org/2298133004/diff/40001/third_party/WebKit/LayoutTests/fast/html/tabindex-nonfocusable.html File third_party/WebKit/LayoutTests/fast/html/tabindex-nonfocusable.html (right): https://codereview.chromium.org/2298133004/diff/40001/third_party/WebKit/LayoutTests/fast/html/tabindex-nonfocusable.html#newcode1 third_party/WebKit/LayoutTests/fast/html/tabindex-nonfocusable.html:1: <!DOCTYPE html> ...
4 years, 3 months ago (2016-09-01 23:27:24 UTC) #7
lunalu1
Hi tkent, Thank you for the feedback. I have made the changes according to your ...
4 years, 3 months ago (2016-09-02 01:07:39 UTC) #8
tkent
lgtm
4 years, 3 months ago (2016-09-02 01:50:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2298133004/60001
4 years, 3 months ago (2016-09-02 01:50:49 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-02 03:37:19 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 03:40:26 UTC) #15
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/8c5fd085e7108025af04004150ee65c09e93d404
Cr-Commit-Position: refs/heads/master@{#416181}

Powered by Google App Engine
This is Rietveld 408576698