Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFormControlElement.h

Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable… (Closed)
Patch Set: Code review update Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 void setNeedsWillValidateCheck(); 149 void setNeedsWillValidateCheck();
150 virtual bool recalcWillValidate() const; 150 virtual bool recalcWillValidate() const;
151 151
152 virtual void resetImpl() { } 152 virtual void resetImpl() { }
153 virtual bool supportsAutofocus() const; 153 virtual bool supportsAutofocus() const;
154 154
155 private: 155 private:
156 bool isFormControlElement() const final { return true; } 156 bool isFormControlElement() const final { return true; }
157 bool alwaysCreateUserAgentShadowRoot() const override { return true; } 157 bool alwaysCreateUserAgentShadowRoot() const override { return true; }
158 158
159 short tabIndex() const final; 159 short tabIndex() const;
160 160
161 bool isValidElement() override; 161 bool isValidElement() override;
162 bool matchesValidityPseudoClasses() const override; 162 bool matchesValidityPseudoClasses() const override;
163 void updateAncestorDisabledState() const; 163 void updateAncestorDisabledState() const;
164 164
165 bool isValidationMessageVisible() const; 165 bool isValidationMessageVisible() const;
166 ValidationMessageClient* validationMessageClient() const; 166 ValidationMessageClient* validationMessageClient() const;
167 167
168 // Requests validity recalc for the form owner, if one exists. 168 // Requests validity recalc for the form owner, if one exists.
169 void formOwnerSetNeedsValidityCheck(); 169 void formOwnerSetNeedsValidityCheck();
(...skipping 25 matching lines...) Expand all
195 { 195 {
196 return element.isFormControlElement(); 196 return element.isFormControlElement();
197 } 197 }
198 198
199 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFormControlElement); 199 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFormControlElement);
200 DEFINE_TYPE_CASTS(HTMLFormControlElement, FormAssociatedElement, control, contro l->isFormControlElement(), control.isFormControlElement()); 200 DEFINE_TYPE_CASTS(HTMLFormControlElement, FormAssociatedElement, control, contro l->isFormControlElement(), control.isFormControlElement());
201 201
202 } // namespace blink 202 } // namespace blink
203 203
204 #endif 204 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp ('k') | third_party/WebKit/Source/core/html/HTMLOutputElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698