third_party/WebKit/Source/core/html/HTMLFieldSetElement.h - Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFieldSetElement.h

Issue 2298133004: Changed the default value of tabIndex of <fieldset> and <output> to be -1 as they are non-focusable… (Closed)

Patch Set: Added a layout test Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/html/tabindex-nonfocusable.html ('K') | « third_party/WebKit/LayoutTests/fast/html/tabindex-nonfocusable.html ('k') | third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLFieldSetElement.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Dirk Mueller (mueller@kde.org)	4 * (C) 2000 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.	5 * Copyright (C) 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 48 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
59 bool areAuthorShadowsAllowed() const override { return false; }	59 bool areAuthorShadowsAllowed() const override { return false; }

60 bool isSubmittableElement() override;	60 bool isSubmittableElement() override;

61 bool alwaysCreateUserAgentShadowRoot() const override { return false; }	61 bool alwaysCreateUserAgentShadowRoot() const override { return false; }

62	62

63 static void invalidateDisabledStateUnder(Element&);	63 static void invalidateDisabledStateUnder(Element&);

64 void refreshElementsIfNeeded() const;	64 void refreshElementsIfNeeded() const;

65	65

66 mutable FormAssociatedElement::List m_associatedElements;	66 mutable FormAssociatedElement::List m_associatedElements;

67 // When dom tree is modified, we have to refresh the m_associatedElements ar ray.	67 // When dom tree is modified, we have to refresh the m_associatedElements ar ray.

68 mutable uint64_t m_documentVersion;	68 mutable uint64_t m_documentVersion;

	69 short tabIndex() const final;
	tkent 2016/09/01 23:27:24 Please move this to the private override block abo Please move this to the private override block above. e.g. to next to \|supportsFocus()\| lunalu1 2016/09/02 01:07:38 Done. Show quoted text On 2016/09/01 23:27:24, tkent wrote: > Please move this to the private override block above. e.g. to next to > \|supportsFocus()\| Done.
69 };	70 };

70	71

71 } // namespace blink	72 } // namespace blink

72	73

73 #endif // HTMLFieldSetElement_h	74 #endif // HTMLFieldSetElement_h

OLD	NEW